Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expected behaviour with multiple mapped properties with different types #425

Closed
jonquet opened this issue Jun 8, 2023 · 7 comments
Closed
Assignees

Comments

@jonquet
Copy link
Contributor

jonquet commented Jun 8, 2023

We have an example of a SKOS resource in AgroPortal, which provides 2 definitons:
https://agroportal.lirmm.fr/ontologies/ANAEETHES/?p=classes

Capture d’écran 2023-06-08 à 05 16 17

Which ends up in the API as
Capture d’écran 2023-06-08 à 05 22 54

(the difference of types creates a non regular JSON structure)

Which ends up in the UI as
Capture d’écran 2023-06-08 à 05 22 11

(Similar situation could happen with synonyms which are also mapped to a unique "synonym" property).

What is the expected behaviour when this situation occurs?
We can expect the display and the JSON being well structured.

@syphax-bouazzouni
Copy link
Contributor

We can expect the display and the JSON being well structured.

So it's more of a UI bug.

When it's an object it needs to be shown as a link (for now, in the future we will fetch more data about it )

I assign @SirineMhedhbi to fix this.

@syphax-bouazzouni
Copy link
Contributor

Fixed with ontoportal-lirmm/bioportal_web_ui#273

@jonquet
Copy link
Contributor Author

jonquet commented Jun 16, 2023

Penser a gèrer le cas ou les valeurs sont des objects (URI) pour les afficher comme des "boutons"

@jonquet jonquet reopened this Jun 16, 2023
@SirineMhedhbi
Copy link

@jonquet Done

@syphax-bouazzouni
Copy link
Contributor

syphax-bouazzouni commented Jun 24, 2023

@jonquet Done

@SirineMhedhbi done where? you need to give a link to your commit fix or new PR and a screenshot so that we can see it.

In this case, the commit is ontoportal-lirmm/bioportal_web_ui@67ff34c

But for the PR, you will need to open a new one as a follow-up of this ontoportal-lirmm/bioportal_web_ui#273 (because already closed)

Thanks;

@SirineMhedhbi
Copy link

@syphax-bouazzouni

okay thanks

image

@SirineMhedhbi
Copy link

@syphax-bouazzouni this is the new PR :
ontoportal-lirmm/bioportal_web_ui#280

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants