Testing libcurl export

Author: agonzc34

CMakeLists.txt

@@ -1,28 +1,39 @@
 cmake_minimum_required(VERSION 3.10)
 project(HFHub CXX)
 
+# Set C++ standard
+set(CMAKE_CXX_STANDARD 17)
+
 # Find CURL package
 find_package(CURL REQUIRED)
+if(NOT CURL_FOUND)
+    message(FATAL_ERROR "CURL not found! Please install libcurl-dev.")
+endif()
 
 # Define the hfhub static library and link it to CURL
 add_library(hfhub STATIC src/huggingface_hub.cpp)
 
 # Ensure CURL is available for consumers
 target_include_directories(hfhub PUBLIC
   $<BUILD_INTERFACE:${CMAKE_CURRENT_SOURCE_DIR}/include>
-  $<INSTALL_INTERFACE:include>
+  $<INSTALL_INTERFACE:${CMAKE_INSTALL_INCLUDEDIR}>
   ${CURL_INCLUDE_DIRS}
 )
+
+target_compile_definitions(hfhub PRIVATE CURL_STATICLIB)
 target_link_libraries(hfhub PUBLIC CURL::libcurl)
 
+# Include GNU Install directories for portability
+include(GNUInstallDirs)
+
 # Export target
 install(TARGETS hfhub
   EXPORT hfhubTargets
-  ARCHIVE DESTINATION lib
-  LIBRARY DESTINATION lib
-  RUNTIME DESTINATION bin
+  ARCHIVE DESTINATION ${CMAKE_INSTALL_LIBDIR}
+  LIBRARY DESTINATION ${CMAKE_INSTALL_LIBDIR}
+  RUNTIME DESTINATION ${CMAKE_INSTALL_BINDIR}
 )
-install(DIRECTORY include/ DESTINATION include)
+install(DIRECTORY include/ DESTINATION ${CMAKE_INSTALL_INCLUDEDIR})
 
 # Generate a CMake config file for hfhub
 include(CMakePackageConfigHelpers)
@@ -35,21 +46,29 @@ write_basic_package_version_file(
 install(EXPORT hfhubTargets
   FILE hfhubTargets.cmake
   NAMESPACE hfhub::
-  DESTINATION lib/cmake/hfhub
+  DESTINATION ${CMAKE_INSTALL_DATADIR}/cmake/hfhub
 )
 
 configure_package_config_file(
   "${CMAKE_CURRENT_SOURCE_DIR}/cmake/hfhubConfig.cmake.in"
   "${CMAKE_CURRENT_BINARY_DIR}/hfhubConfig.cmake"
-  INSTALL_DESTINATION lib/cmake/hfhub
+  INSTALL_DESTINATION ${CMAKE_INSTALL_DATADIR}/cmake/hfhub
 )
 
 install(FILES
   "${CMAKE_CURRENT_BINARY_DIR}/hfhubConfig.cmake"
   "${CMAKE_CURRENT_BINARY_DIR}/hfhubConfigVersion.cmake"
-  DESTINATION lib/cmake/hfhub
+  DESTINATION ${CMAKE_INSTALL_DATADIR}/cmake/hfhub
 )
 
+# Define the demo executable
 add_executable(hfhub_demo src/main.cpp)
+
+# Link demo to hfhub
 target_link_libraries(hfhub_demo hfhub)
-install(TARGETS hfhub_demo DESTINATION bin)
+
+# Ensure hfhub_demo has necessary includes
+target_include_directories(hfhub_demo PRIVATE include)
+
+# Install the demo executable
+install(TARGETS hfhub_demo DESTINATION ${CMAKE_INSTALL_BINDIR})