Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iOS builds not approved by App Store due to unpinned GoogleMLKit/TextRecognition version #14

Closed
Kommandat opened this issue Sep 11, 2021 · 3 comments

Comments

@Kommandat
Copy link

There was a thread in the Expo forums on how iOS builds were being rejected by the App store due to the following error:

ITMS-90562: Invalid Bundle - The app cannot be processed because options not allowed to be embedded in bitcode are detected in the submission. It is likely that you are not building the app with the toolchain provided in Xcode. Rebuild your entire app with the latest GM Xcode and submit the app again. 

The solution was to pin the GoogleMLKit/TextRecognition pod to version 2.2.0 per Google's release notes [here](GoogleMLKit/TextRecognition pod). This solves the build issue, but the downside is that it uses MLKit's Text Recognition v1 instead of Text Recognition v2 (in beta).

Currently, I applied this solution in my project project using patch-package, but are we open to pinning the version number to 2.2.0 in the .podspec file here? It's a simple code change and I'd like to make it & contribute if possible.

Thanks!

@Kommandat Kommandat changed the title iOS builds not approved by App Store connect due to unpinned GoogleMLKit/TextRecognition version iOS builds not approved by App Store due to unpinned GoogleMLKit/TextRecognition version Sep 11, 2021
@Noitidart
Copy link

Noitidart commented Sep 11, 2021

@agoldis is pinning the right thing to do? Because it makes it use old version of text recognition. Does it only affect certain react-native versions? Or does it affect all?

I also had this problem by the way.

@agoldis
Copy link
Owner

agoldis commented Sep 12, 2021

@Kommandat @Noitidart
https://developers.google.com/ml-kit/vision/text-recognition/ios and https://developers.google.com/ml-kit/vision/text-recognition/v2/ios both have the version pinned.
I think letting the app "pass" App store review is preferred by majority of users. One can always patch if needed. If there's an important use case unpin the version we can always revert.

@Noitidart
Copy link

Noitidart commented Sep 12, 2021

Got it thanks for the way fast help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants