Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix check_termination_and_human_reply() when called with empty list as messages #1132

Merged
merged 1 commit into from
Feb 25, 2025

Conversation

davorrunje
Copy link
Collaborator

Why are these changes needed?

Related issue number

Closes #1124

Checks

@davorrunje davorrunje linked an issue Feb 25, 2025 that may be closed by this pull request
@davorrunje davorrunje changed the title Fix check_termination_and_human_reply() when called with messages == [] Fix check_termination_and_human_reply() when called with empty list as messages Feb 25, 2025
@kumaranvpl kumaranvpl enabled auto-merge February 25, 2025 10:49
@kumaranvpl kumaranvpl added this pull request to the merge queue Feb 25, 2025
Merged via the queue into main with commit 4296e8c Feb 25, 2025
17 checks passed
@kumaranvpl kumaranvpl deleted the 1124-bug-indexerror branch February 25, 2025 11:21
Copy link

codecov bot commented Feb 25, 2025

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
autogen/agentchat/conversable_agent.py 0.00% 1 Missing and 1 partial ⚠️

❗ There is a different number of reports uploaded between BASE (bb8b41a) and HEAD (ff25636). Click for more details.

HEAD has 1201 uploads less than BASE
Flag BASE (bb8b41a) HEAD (ff25636)
3.13 84 0
ubuntu-latest 138 1
commsagent-discord 7 0
optional-deps 137 0
browser-use 7 0
macos-latest 104 0
3.9 73 0
commsagent-slack 9 0
windows-latest 104 0
core-without-llm 9 1
3.11 62 1
3.10 92 0
commsagent-telegram 9 0
3.12 35 0
jupyter-executor 9 0
retrievechat-pgvector 10 0
graph-rag-falkor-db 6 0
retrievechat-qdrant 11 0
retrievechat-mongodb 10 0
twilio 9 0
gpt-assistant-agent 3 0
anthropic 16 0
gemini 14 0
teachable 4 0
retrievechat 10 0
lmm 4 0
websurfer 15 0
cerebras 14 0
interop 13 0
agent-eval 1 0
cohere 15 0
groq 14 0
llama-index-agent 3 0
retrievechat-couchbase 3 0
core-llm 3 0
deepseek 1 0
openai 1 0
integration 12 0
crawl4ai 13 0
falkordb 2 0
autobuild 1 0
docs 6 0
interop-crewai 9 0
interop-langchain 9 0
websockets 9 0
interop-pydantic-ai 9 0
neo4j 2 0
mistral 14 0
ollama 14 0
together 14 0
long-context 3 0
bedrock 14 0
reasoning 14 0
Files with missing lines Coverage Δ
autogen/agentchat/conversable_agent.py 66.59% <0.00%> (-10.00%) ⬇️

... and 61 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: IndexError
2 participants