Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix failing core llm tests because of missing websockets dependency #1100

Merged
merged 14 commits into from
Feb 24, 2025
Merged

Fix failing core llm tests because of missing websockets dependency #1100

merged 14 commits into from
Feb 24, 2025

Conversation

kumaranvpl
Copy link
Collaborator

Why are these changes needed?

Related issue number

Closes #1099

Checks

davorrunje
davorrunje approved these changes Feb 24, 2025
View reviewed changes
@davorrunje davorrunje enabled auto-merge February 24, 2025 09:36
@davorrunje davorrunje added this pull request to the merge queue Feb 24, 2025
Merged via the queue into main with commit 1792140 Feb 24, 2025
21 checks passed
@davorrunje davorrunje deleted the fix-failing-core-llm-tests branch February 24, 2025 09:50
@codecov Codecov
Copy link

codecov bot commented Feb 24, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Files with missing lines Coverage Δ
...hat/realtime/experimental/clients/gemini/client.py 85.04% <100.00%> (ø)
...t/realtime/experimental/clients/oai/base_client.py 86.90% <100.00%> (+34.46%) ⬆️

... and 36 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davorrunje davorrunje davorrunje approved these changes

Assignees

@davorrunje davorrunje

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix failing core llm openai tests
2 participants
@kumaranvpl @davorrunje