Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct hook processing order on ConversableAgent.a_generate_reply #1096

Merged
merged 1 commit into from
Feb 24, 2025

Conversation

marklysze
Copy link
Collaborator

Why are these changes needed?

The hook processing order on generate_reply and a_generate_reply is different.

Correcting a_generate_reply to be:

  • update_agent_state
  • process_last_received_message
  • process_all_messages_before_reply

Related issue number

N/A

Checks

@marklysze marklysze added the bug Something isn't working label Feb 24, 2025
@marklysze marklysze self-assigned this Feb 24, 2025
@davorrunje davorrunje added this pull request to the merge queue Feb 24, 2025
Merged via the queue into main with commit eb5566c Feb 24, 2025
100 of 504 checks passed
@davorrunje davorrunje deleted the hookcorrectorder branch February 24, 2025 07:59
Copy link

codecov bot commented Feb 24, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ There is a different number of reports uploaded between BASE (9c79c45) and HEAD (cf3ddc5). Click for more details.

HEAD has 974 uploads less than BASE
Flag BASE (9c79c45) HEAD (cf3ddc5)
3.13 88 21
ubuntu-latest 143 30
optional-deps 141 66
3.9 78 26
3.10 99 27
browser-use 6 3
macos-latest 108 25
windows-latest 119 26
3.11 66 4
3.12 39 3
retrievechat-pgvector 10 7
retrievechat 15 7
agent-eval 1 0
gpt-assistant-agent 3 0
retrievechat-qdrant 14 6
graph-rag-falkor-db 6 0
teachable 4 0
retrievechat-mongodb 10 7
twilio 9 0
anthropic 16 0
cerebras 14 0
websurfer 15 0
gemini 15 0
retrievechat-couchbase 3 0
llama-index-agent 3 0
lmm 4 0
groq 14 0
mistral 14 0
long-context 3 0
interop 13 0
together 14 0
crawl4ai 13 0
docs 6 0
interop-crewai 9 0
interop-langchain 9 0
interop-pydantic-ai 9 0
websockets 9 0
bedrock 14 0
ollama 14 0
cohere 15 0
swarm 13 0
reasoning 14 0
falkordb 2 0
core-llm 3 0
autobuild 1 0
deepseek 1 0
neo4j 2 0
integration 11 0
Files with missing lines Coverage Δ
autogen/agentchat/conversable_agent.py 66.69% <100.00%> (-7.56%) ⬇️

... and 29 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants