-
Notifications
You must be signed in to change notification settings - Fork 239
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pass system message as system_instruction to Gemini #1011. #1090
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution. Thanks to this PR, I found some issues with the current documentation in https://docs.ag2.ai/docs/user-guide/models/google-gemini.
Co-authored-by: Chi Wang <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @liminma!
Codecov ReportAttention: Patch coverage is
|
Glad to have contributed to the project! Thanks for merging. |
@rjambrecic
Why are these changes needed?
Gemini supports system instructions. Sending the system_message as a system_instruction could potentially be more effective.
Related issue number
Fixes #1011
Checks