Refactor query engine interface #1058

AgentGenie · 2025-02-20T05:52:16Z

Why are these changes needed?

Refactor to use protocols for vector db query engine.

I've included any doc changes needed for https://docs.ag2.ai/. See https://docs.ag2.ai/docs/contributor-guide/documentation to build and test documentation locally.
I've added tests (if relevant) corresponding to the changes introduced in this PR.
I've made sure all auto checks have passed.

AgentGenie · 2025-02-20T05:54:33Z

@Eric-Shang please use this Protocol and update DoclingMdQueryEngine and Document agent and related tests and notebook accordingly.
cc @sitloboi2012

davorrunje · 2025-02-20T12:20:12Z

I fixed typing and merge everything together in this PR: https://github.com/ag2ai/ag2/pull/1065/files

Refactor query engine interface

78cc764

AgentGenie requested a review from Eric-Shang February 20, 2025 05:52

AgentGenie requested a deployment to openai1 February 20, 2025 05:52 — with GitHub Actions Waiting

AgentGenie requested a deployment to openai1 February 20, 2025 05:53 — with GitHub Actions Waiting

davorrunje self-requested a review February 20, 2025 10:17

davorrunje self-assigned this Feb 20, 2025

davorrunje enabled auto-merge February 20, 2025 10:20

resolve conflicts

fccb4d3

davorrunje approved these changes Feb 20, 2025

View reviewed changes

davorrunje disabled auto-merge February 20, 2025 12:13

davorrunje merged commit 7c13751 into main Feb 20, 2025
31 checks passed

davorrunje deleted the rag_refactor branch February 20, 2025 12:13