Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Investigate moving build scripts from Bash to Python (3) #1642

Open
karianna opened this issue Mar 31, 2020 · 5 comments
Open

Investigate moving build scripts from Bash to Python (3) #1642

karianna opened this issue Mar 31, 2020 · 5 comments
Labels
enhancement Issues that enhance the code or documentation of the repo in any way refactoring Issues that focus on moving around the codebase inside or between repos

Comments

@karianna
Copy link
Contributor

Our bash scripts have started to grow to a size and scale that isn't the best fit for a scripting/shell environment.

We could potentially see benefits of:

  • Having a DSL
  • Reducing duplicate code
  • Simplify templating / configuring
  • Better testing support.

Things to check would be:

  • Can we install Python 2/3 on all of our supported platforms?
  • Do we have Python skillsets?
  • Is there an appetite for a migration?
@karianna karianna added the enhancement Issues that enhance the code or documentation of the repo in any way label Mar 31, 2020
@sxa
Copy link
Member

sxa commented Mar 31, 2020

My 2p on the subject: As per conversation elsewhere, I'm not overly keen on another re-write that's going to inevitable introduce instabilities, although I would be in favour of simplifying the current spaghetti scripts as it's hard work to see where things need to be changed. Related: #957

@gdams gdams changed the title Investigate moving build scripts from Bash to Python (2 or 3) Investigate moving build scripts from Bash to Python (3) Jun 10, 2020
@d3r3kk
Copy link
Contributor

d3r3kk commented Jun 10, 2020

Good discussion here: https://adoptopenjdk.slack.com/archives/C09NW3L2J/p1591777851011100

@d3r3kk
Copy link
Contributor

d3r3kk commented Jun 10, 2020

I'll just say that since Python 2 is deprecated, and we wouldn't want to rewrite these scripts any time in the future.

@d3r3kk
Copy link
Contributor

d3r3kk commented Jun 10, 2020

What platforms do we need to build on, so we can determine the availability of a replacement to Bash on each?

@M-Davies
Copy link

@d3r3kk We build all of the platforms that we advertise on the website as well as some extra "alpha" builds

@M-Davies M-Davies added the refactoring Issues that focus on moving around the codebase inside or between repos label Feb 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement Issues that enhance the code or documentation of the repo in any way refactoring Issues that focus on moving around the codebase inside or between repos
Projects
Adoptium Backlog
Status: Todo
Milestone
No milestone
Development

No branches or pull requests
4 participants
@karianna @sxa @d3r3kk @M-Davies