Add feature to specify customJvmOpts=XXXX in APPLICATION_OPTIONS #6004
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andrew Leonard <[email protected]>
Signed-off-by: Andrew Leonard <[email protected]>
Signed-off-by: Andrew Leonard <[email protected]>
Signed-off-by: Andrew Leonard <[email protected]>
Signed-off-by: Andrew Leonard <[email protected]>
smlambert
approved these changes
Mar 5, 2025
sophia-guo
reviewed
Mar 5, 2025
| @@ -20,7 +20,7 @@ | |||
| <variation>NoOptions</variation> | |||
| </variations> | |||
| <command>$(GEN_JTB_GENERIC) testsuite=RUNTIME tests="$(JCKRUNTIME_CUSTOM_TARGET)" isCustomTarget="isCustomTarget"; \ | |||
| $(EXEC_RUNTIME_TEST); \ | |||
| $(EXEC_RUNTIME_TEST_WITH_AGENT); \ | |||
There was a problem hiding this comment.
Will this change work for all jck-runtime-** targets? It seems only three targets are using this $(EXEC_RUNTIME_TEST_WITH_AGENT) and all others are using $(EXEC_RUNTIME_TEST)?
There was a problem hiding this comment.
@sophia-guo yes, whether it actually needs the agent does not matter it will just start then stop the agent process..
I tested one that was just EXEC_RUNTIME_TEST here: https://ci.eclipse.org/temurin-compliance/job/Grinder/4839/console
worked fine
sophia-guo
approved these changes
Mar 6, 2025
|
FYI @llxia |
judovana
pushed a commit
to judovana/aqa-tests
that referenced
this pull request
Mar 11, 2025
…ptium#6004) * Add support for customJvmOpts for test and agent in APPLICATION_OPTIONS Signed-off-by: Andrew Leonard <[email protected]> * Add support for customJvmOpts for test and agent in APPLICATION_OPTIONS Signed-off-by: Andrew Leonard <[email protected]> * Add support for customJvmOpts for test and agent in APPLICATION_OPTIONS Signed-off-by: Andrew Leonard <[email protected]> * Add support for customJvmOpts for test and agent in APPLICATION_OPTIONS Signed-off-by: Andrew Leonard <[email protected]> * Add support for customJvmOpts for test and agent in APPLICATION_OPTIONS Signed-off-by: Andrew Leonard <[email protected]> --------- Signed-off-by: Andrew Leonard <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add feature to specify customJvmOpts=XXXX in APPLICATION_OPTIONS for jck.mk to pass to jck tests and agent JVM processes:
temirin-compliance runs successfully tested with APPLICATION_OPTIONS empty, to test jck.mk logic does not affect other tests
temirin-compliance runs successfully tested with customJvmOpts=-Djava.net.preferIPv4Stack=true