Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exclude jdk_beans tests on win JDKversions 8,17,23 #5978

Merged
merged 1 commit into from
Feb 27, 2025
Merged

Exclude jdk_beans tests on win JDKversions 8,17,23 #5978

merged 1 commit into from
Feb 27, 2025

Conversation

annaibm
Copy link
Contributor

@annaibm annaibm commented Feb 25, 2025

  • Exclude jdk_beans subtests for win for versions 8,17,23

related:eclipse-openj9/openj9#20531

@annaibm
Copy link
Contributor Author

annaibm commented Feb 25, 2025

Grinder runs:

JDK8 https://hyc-runtimes-jenkins.swg-devops.com/job/Grinder/48361/
JDK17 https://hyc-runtimes-jenkins.swg-devops.com/job/Grinder/48360/
JDK23 https://hyc-runtimes-jenkins.swg-devops.com/job/Grinder/48359/

@annaibm annaibm marked this pull request as ready for review February 26, 2025 14:10
LongyuZhang
LongyuZhang approved these changes Feb 26, 2025
View reviewed changes
Copy link
Contributor

@LongyuZhang LongyuZhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@llxia
Copy link
Contributor

llxia commented Feb 26, 2025

What about the rest of JDK versions (i.e., 11, 24+)?

@annaibm
Copy link
Contributor Author

annaibm commented Feb 26, 2025 •
edited
Loading

What about the rest of JDK versions (i.e., 11, 24+)?

The tests have passed for JDK 11 and JDK 21 as seen below:

JDK 11: Grinder 48172
JDK 21: Grinder 48188
However, still need to check on JDK 24.
JDK24: https://hyc-runtimes-jenkins.swg-devops.com/job/Grinder/48410/ - running

@llxia
Copy link
Contributor

llxia commented Feb 26, 2025

I suspect these are machine issues. Could you please rerun the failed JDK8/17/23 tests on a machine that passed JDK11/21 tests (i.e., win16x86-rtp-rt1-1)?

@annaibm
Exclude jdk_beans tests on win JDKversions 8,17,23
c4997a3 
- Exclude jdk_beans subtests for win for versions 8,17,23

related:eclipse-openj9/openj9#20531
Signed-off-by: Anna Babu Palathingal <[email protected]>
@annaibm
Copy link
Contributor Author

annaibm commented Feb 27, 2025

I suspect these are machine issues. Could you please rerun the failed JDK8/17/23 tests on a machine that passed JDK11/21 tests (i.e., win16x86-rtp-rt1-1)?

JDK8/17/23 is reran on m/cs that passed with JDK11/21 but subtests still failed:
win16x86-rtp-rt1-1.fyre.ibm.com
JDK8:
https://hyc-runtimes-jenkins.swg-devops.com/job/Grinder/48417/
JDK17
[win10x86-rtp-rt6-1.fyre.ibm.com]
https://hyc-runtimes-jenkins.swg-devops.com/job/Grinder/48435/
JDK23
win10x86-rtp-rt5-1.fyre.ibm.com
https://hyc-runtimes-jenkins.swg-devops.com/job/Grinder/48419/
JDK24
https://hyc-runtimes-jenkins.swg-devops.com/job/Grinder/48410/

@llxia
Copy link
Contributor

llxia commented Feb 27, 2025

Thanks @annaibm

@llxia llxia merged commit 8e148d5 into adoptium:master Feb 27, 2025
3 checks passed
judovana pushed a commit to judovana/aqa-tests that referenced this pull request Mar 11, 2025
@annaibm @judovana
Exclude jdk_beans tests on win JDKversions 8,17,23 (adoptium#5978)
7b0b30f 
- Exclude jdk_beans subtests for win for versions 8,17,23

related:eclipse-openj9/openj9#20531

Signed-off-by: Anna Babu Palathingal <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@llxia llxia llxia approved these changes

@LongyuZhang LongyuZhang LongyuZhang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@annaibm @llxia @LongyuZhang