-
-
Notifications
You must be signed in to change notification settings - Fork 322
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update external sub target dist to upper level as a common target #5939
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sophia Guo <[email protected]>
Signed-off-by: Sophia Guo <[email protected]>
Signed-off-by: Sophia Guo <[email protected]>
Also remove unused targets Signed-off-by: Sophia Guo <[email protected]>
karianna
approved these changes
Feb 3, 2025
Changes are common to all externals. @LongyuZhang could you please double check if it is good with CRIU tests? |
dc63101
to
39fba56
Compare
Signed-off-by: Sophia Guo <[email protected]>
LongyuZhang
approved these changes
Feb 4, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. CRIU container test passed too (hyc_grinder 47374)
judovana
pushed a commit
to judovana/aqa-tests
that referenced
this pull request
Mar 11, 2025
…optium#5939) * Copy Dockefile to TEST_ROOT Signed-off-by: Sophia Guo <[email protected]> * Move comment job to uplevel Signed-off-by: Sophia Guo <[email protected]> * Try not use antcall Signed-off-by: Sophia Guo <[email protected]> * Update dist target and move to upper level as a common target Also remove unused targets Signed-off-by: Sophia Guo <[email protected]> * Only archive Dockerfile under jvmtest Signed-off-by: Sophia Guo <[email protected]> --------- Signed-off-by: Sophia Guo <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update to copy generated dockerfile as a condition to check external tests SHAs.
Close #5825