Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

debounced validations does not work #102

Closed
koemeet opened this issue Jan 16, 2016 · 3 comments
Closed

debounced validations does not work #102

koemeet opened this issue Jan 16, 2016 · 3 comments

Comments

@koemeet
Copy link

koemeet commented Jan 16, 2016

The debounce is not really debouncing because of the following code: https://github.com/offirgolan/ember-cp-validations/blob/master/addon/validations/factory.js#L250

You cannot pass an anonymous function as the debounce method, but it should rather pass in a reference of a function (http://emberjs.com/api/classes/Ember.run.html#method_debounce).
@offirgolan
Copy link
Collaborator

👍 Ill issue out a fix for this soon

@offirgolan offirgolan mentioned this issue Jan 17, 2016
Merged
@koemeet
Copy link
Author

koemeet commented Jan 17, 2016

Thanks @offirgolan quick fix! 👍

@offirgolan
Copy link
Collaborator

No problem! v2.2.1 has been release to npm 😸. Thanks for pointing this out

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@offirgolan @koemeet