fix(menu): allow menu-item to support arbitrary element as the submenu root #4720
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TarunAdobe
force-pushed
the
ttomar/swc-329
branch
from
90b7d35 to
2de878d
Compare
Lighthouse scores
What is this?Lighthouse scores comparing the documentation site built from the PR ("Branch") to that of the production documentation site ("Latest") and the build currently on Transfer Size
Request Count
|
TarunAdobe
changed the title
Pull Request Test Coverage Report for Build 10733312755Details
💛 - Coveralls |
TarunAdobe
force-pushed
the
ttomar/swc-329
branch
from
2de878d to
225819a
Compare
TarunAdobe
changed the title
TarunAdobe
force-pushed
the
ttomar/swc-329
branch
from
225819a to
1751f14
Compare
TarunAdobe
changed the title
1 task
|
Great Start! Can you also create a storybook link for this usage? |
Tachometer resultsChromeaction-menu permalinktest-basic
test-directive permalink
test-lazy permalink
test-open-close-directive permalink
test-open-close permalink
breadcrumbs permalinkbasic-test
combobox permalinkbasic-test
light-dom-test permalink
menu permalinktest-basic
picker permalinkbasic-test
split-button permalinkbasic-test
Firefoxaction-menu permalinktest-basic
test-directive permalink
test-lazy permalink
test-open-close-directive permalink
test-open-close permalink
breadcrumbs permalinkbasic-test
combobox permalinkbasic-test
light-dom-test permalink
menu permalinktest-basic
picker permalinkbasic-test
split-button permalinkbasic-test
|
TarunAdobe
force-pushed
the
ttomar/swc-329
branch
from
5440c77 to
8314907
Compare
Rajdeepc
previously approved these changes
Sep 5, 2024
Co-authored-by: Rúben Carvalho <[email protected]>
Rajdeepc
approved these changes
Sep 6, 2024
nikkimk
pushed a commit
that referenced
this pull request
Sep 13, 2024
…u root (#4720) * fix(menu): allow using non-menu-item element as submenu root * chore(menu): fixed broken test * chore(menu): added a custom root submenu example in storybook * chore(menu): updated docs --------- Co-authored-by: Rúben Carvalho <[email protected]>
nikkimk
pushed a commit
that referenced
this pull request
Sep 13, 2024
…u root (#4720) * fix(menu): allow using non-menu-item element as submenu root * chore(menu): fixed broken test * chore(menu): added a custom root submenu example in storybook * chore(menu): updated docs --------- Co-authored-by: Rúben Carvalho <[email protected]>
nikkimk
pushed a commit
that referenced
this pull request
Sep 13, 2024
…u root (#4720) * fix(menu): allow using non-menu-item element as submenu root * chore(menu): fixed broken test * chore(menu): added a custom root submenu example in storybook * chore(menu): updated docs --------- Co-authored-by: Rúben Carvalho <[email protected]>
nikkimk
pushed a commit
that referenced
this pull request
Sep 13, 2024
…u root (#4720) * fix(menu): allow using non-menu-item element as submenu root * chore(menu): fixed broken test * chore(menu): added a custom root submenu example in storybook * chore(menu): updated docs --------- Co-authored-by: Rúben Carvalho <[email protected]>
nikkimk
pushed a commit
that referenced
this pull request
Sep 13, 2024
…u root (#4720) * fix(menu): allow using non-menu-item element as submenu root * chore(menu): fixed broken test * chore(menu): added a custom root submenu example in storybook * chore(menu): updated docs --------- Co-authored-by: Rúben Carvalho <[email protected]>
nikkimk
pushed a commit
that referenced
this pull request
Sep 13, 2024
…u root (#4720) * fix(menu): allow using non-menu-item element as submenu root * chore(menu): fixed broken test * chore(menu): added a custom root submenu example in storybook * chore(menu): updated docs --------- Co-authored-by: Rúben Carvalho <[email protected]>
nikkimk
pushed a commit
that referenced
this pull request
Sep 13, 2024
…u root (#4720) * fix(menu): allow using non-menu-item element as submenu root * chore(menu): fixed broken test * chore(menu): added a custom root submenu example in storybook * chore(menu): updated docs --------- Co-authored-by: Rúben Carvalho <[email protected]>
nikkimk
pushed a commit
that referenced
this pull request
Sep 13, 2024
…u root (#4720) * fix(menu): allow using non-menu-item element as submenu root * chore(menu): fixed broken test * chore(menu): added a custom root submenu example in storybook * chore(menu): updated docs --------- Co-authored-by: Rúben Carvalho <[email protected]>
nikkimk
pushed a commit
that referenced
this pull request
Sep 13, 2024
…u root (#4720) * fix(menu): allow using non-menu-item element as submenu root * chore(menu): fixed broken test * chore(menu): added a custom root submenu example in storybook * chore(menu): updated docs --------- Co-authored-by: Rúben Carvalho <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Allow using non-menu-item components as submenu.
Related issue(s)
Motivation and context
Using arbitrary components as submenu items and clicking them produces the TypeError:
Cannot read properties of undefined (reading 'selectionRoot') in Menu.handlePointerBasedSelection
How has this been tested?
Added a test and it passed.
Did it pass in Desktop?
Did it pass in Mobile?
Did it pass in iPad?
Screenshots (if appropriate)
Types of changes
Checklist
Best practices
This repository uses conventional commit syntax for each commit message; note that the GitHub UI does not use this by default so be cautious when accepting suggested changes. Avoid the "Update branch" button on the pull request and opt instead for rebasing your branch against
main.