fix(slider): update variant attribute correctly

[TarunAdobe]

Description

Fixed SWC-454

Motivation and context

Slider was getting stuck in a infinite recursive loop on using variant and size attributes together.

How has this been tested?

• Test case 1

  1. Go here
  2. Do this

• Test case 2

  1. Go here
  2. Do this

• Did it pass in Desktop?

• Did it pass in Mobile?

• Did it pass in iPad?

Screenshots (if appropriate)

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)
• Chore (minor updates related to the tooling or maintenance of the repository, does not impact compiled assets)

Checklist

• I have signed the Adobe Open Source CLA.
• My code follows the code style of this project.
• If my change required a change to the documentation, I have updated the documentation in this pull request.
• I have read the CONTRIBUTING document.
• I have added tests to cover my changes.
• All new and existing tests passed.
• I have reviewed at the Accessibility Practices for this feature, see: Aria Practices

Best practices

This repository uses conventional commit syntax for each commit message; note that the GitHub UI does not use this by default so be cautious when accepting suggested changes. Avoid the "Update branch" button on the pull request and opt instead for rebasing your branch against main.

[github-actions]

Branch preview

• Documentation Site
• Storybook

Visual regression test results

When a visual regression test fails (or has previously failed while working on this branch), its results can be found in the following URLs:

• High Contrast Mode | Medium | LTR
• Spectrum | Lightest | Medium | LTR
• Spectrum | Lightest | Medium | RTL
• Spectrum | Lightest | Large | LTR
• Spectrum | Lightest | Large | RTL
• Spectrum | Light | Medium | LTR
• Spectrum | Light | Medium | RTL
• Spectrum | Light | Large | LTR
• Spectrum | Light | Large | RTL
• Spectrum | Dark | Medium | LTR
• Spectrum | Dark | Medium | RTL
• Spectrum | Dark | Large | LTR
• Spectrum | Dark | Large | RTL
• Spectrum | Darkest | Medium | LTR
• Spectrum | Darkest | Medium | RTL
• Spectrum | Darkest | Large | LTR
• Spectrum | Darkest | Large | RTL
• Express | Lightest | Medium | LTR
• Express | Lightest | Medium | RTL
• Express | Lightest | Large | LTR
• Express | Lightest | Large | RTL
• Express | Light | Medium | LTR
• Express | Light | Medium | RTL
• Express | Light | Large | LTR
• Express | Light | Large | RTL
• Express | Dark | Medium | LTR
• Express | Dark | Medium | RTL
• Express | Dark | Large | LTR
• Express | Dark | Large | RTL
• Express | Darkest | Medium | LTR
• Express | Darkest | Medium | RTL
• Express | Darkest | Large | LTR
• Express | Darkest | Large | RTL
• Spectrum-two | Light | Medium | LTR
• Spectrum-two | Light | Medium | RTL
• Spectrum-two | Light | Large | LTR
• Spectrum-two | Light | Large | RTL
• Spectrum-two | Dark | Medium | LTR
• Spectrum-two | Dark | Medium | RTL
• Spectrum-two | Dark | Large | LTR
• Spectrum-two | Dark | Large | RTL

[github-actions]

Lighthouse scores

Category	Latest (report)	Main (report)	Branch (report)
Performance	0.99	0.99	0.99
Accessibility	1	1	1
Best Practices	1	1	1
SEO	1	0.92	0.92
PWA	1	1	1

What is this?

Lighthouse scores comparing the documentation site built from the PR ("Branch") to that of the production documentation site ("Latest") and the build currently on main ("Main"). Higher scores are better, but note that the SEO scores on Netlify URLs are artifically constrained to 0.92.

Transfer Size

Category	Latest	Main	Branch
Total	225.936 kB	214.188 kB 🏆	214.442 kB
Scripts	55.251 kB	49.638 kB 🏆	49.737 kB
Stylesheet	34.705 kB	30.092 kB 🏆	30.161 kB
Document	6.209 kB	5.438 kB 🏆	5.441 kB
Font	126.852 kB	126.604 kB 🏆	126.754 kB

Request Count

Category	Latest	Main	Branch
Total	52	52	52
Scripts	41	41	41
Stylesheet	5	5	5
Document	1	1	1
Font	2	2	2

[coveralls]

Pull Request Test Coverage Report for Build 10665265256

Details

• 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage decreased (-0.003%) to 98.199%

---

Totals
Change from base Build 10611561374:	-0.003%
Covered Lines:	32500
Relevant Lines:	32931

---

💛 - Coveralls

[Rajdeepc]

Good one! Very minute but very neatly picked