fix(number-field): update IME change detection #4672
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tachometer resultsChromenumber-field permalinkbasic-test
slider permalinktest-basic
Firefoxnumber-field permalinkbasic-test
slider permalinktest-basic
|
rubencarvalho
force-pushed
the
ruben/fix-double-byte-safari-number-field
branch
from
e4d2eec to
d62623d
Compare
rubencarvalho
force-pushed
the
ruben/fix-double-byte-safari-number-field
branch
from
94628ef to
ef04db6
Compare
rubencarvalho
changed the title
rubencarvalho
force-pushed
the
ruben/fix-double-byte-safari-number-field
branch
from
ef04db6 to
c45ff1e
Compare
rubencarvalho
commented
Aug 19, 2024
| @@ -214,7 +228,13 @@ export class NumberField extends TextfieldBase { | |||
| private valueBeforeFocus: string = ''; | |||
| private isIntentDecimal: boolean = false; | |||
|
|
|||
| private convertValueToNumber(value: string): number { | |||
| private convertValueToNumber(inputValue: string): number { | |||
| // Normalize full-width characters to their ASCII equivalents | |||
There was a problem hiding this comment.
Without normalizing this value (remapping the multi-byte characters) before the input manipulation, we would get NaN.
| @@ -502,6 +502,18 @@ describe('NumberField', () => { | |||
| el.value = 52; | |||
| expect(changeSpy.callCount).to.equal(0); | |||
| }); | |||
| it('handles IME input correctly and dispatches change event', async () => { | |||
There was a problem hiding this comment.
This test covers both the NaN case and the change event.
| private setValue(value: number = this.value): void { | ||
| this.value = value; | ||
| private setValue(newValue: number = this.value): void { | ||
| // Capture previous value for accurate IME change detection |
There was a problem hiding this comment.
For IME input in Safari, the value conversion process would cause this.value and this.lastCommitedValue to be identical at the time of the comparison, even though a change had happened. So I added previousValue to hold the value of this.lastCommitedValue before the update to this.value, which fixed it! :)
TarunAdobe
approved these changes
Aug 19, 2024
nikkimk
pushed a commit
that referenced
this pull request
Aug 20, 2024
TarunAdobe
pushed a commit
that referenced
this pull request
Aug 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR resolves an issue in Safari where multi-byte characters were being improperly converted, resulting in
NaNand updates the function responsible for triggering thechangeevent to ensure it behaves consistently across all supported browsers.Related issue(s)
changeevent is not triggered for double byte characters on Safari #4579Motivation and context
sp-number-field+ Safari + IME were in need of some love.How has this been tested?
Storybook actions
/storybook/index.html?path=/story/number-field--defaultsp-number-fieldcomponentactionstab onEnterkeypress andblurfor the expected behaviourDid it pass in Desktop?
Did it pass in Mobile?
Did it pass in iPad (simulator)?
Types of changes
Checklist
Best practices
This repository uses conventional commit syntax for each commit message; note that the GitHub UI does not use this by default so be cautious when accepting suggested changes. Avoid the "Update branch" button on the pull request and opt instead for rebasing your branch against
main.