Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: sp-picker-button quiet styles need to be updated #4345

Closed
1 task done
Rocss opened this issue Apr 30, 2024 · 0 comments · Fixed by #4383
Closed
1 task done

[Bug]: sp-picker-button quiet styles need to be updated #4345

Rocss opened this issue Apr 30, 2024 · 0 comments · Fixed by #4383
Labels
bug Something isn't working Component: Picker Button triage An issue needing triage

Comments

@Rocss
Copy link
Contributor

Rocss commented Apr 30, 2024

Code of conduct

  • I agree to follow this project's code of conduct.

Impacted component(s)

sp-picker-button

Expected behavior

spectrum-PickerButton--low was removed, according to: https://opensource.adobe.com/spectrum-css/pickerbutton.html#migrationguide
Therefore, we should update this component's CSS to process spectrum-PickerButton--quiet instead of spectrum-PickerButton--low for quiet style.

Actual behavior

Observe in the documentation how the quiet style is identical to the default one:

Screenshot 2024-04-30 at 14 16 47

Screenshots

No response

What browsers are you seeing the problem in?

No response

How can we reproduce this issue?

  1. Go to https://opensource.adobe.com/spectrum-web-components/components/picker-button/#quiet
  2. Observe that the quiet styles are no longer applied

Sample code that illustrates the problem

No response

Logs taken while reproducing problem

No response

@Rocss Rocss added bug Something isn't working triage An issue needing triage Component: Picker Button labels Apr 30, 2024
@Rocss Rocss linked a pull request May 2, 2024 that will close this issue
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Component: Picker Button triage An issue needing triage
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant