Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(overlay): ensure manual overlays persist through interactions outside of their subtree #3788

Merged
merged 1 commit into from
Nov 9, 2023
Merged

fix(overlay): ensure manual overlays persist through interactions outside of their subtree #3788

merged 1 commit into from
Nov 9, 2023
+49 −2

Conversation

Westbrook
Copy link
Contributor

Description

Persist <sp-overlay type="manual"> elements through interaction that occur outside of their subtree, as is documented/expected/etc but was missed... 😞

Related issue(s)

How has this been tested?

  • Test case 1
    1. Go here
    2. Ensure "type" is set to "manual" in the story controls
    3. Open the overlay
    4. Click outside of it
    5. See that it does not close

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • If my change required a change to the documentation, I have updated the documentation in this pull request.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 8, 2023

Branch Preview

Visual regression test results

When a visual regression test fails (or has previously failed while working on this branch), its results can be found in the following URLs:

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 8, 2023 •
edited
Loading

Tachometer results

Chrome

action-bar permalink

Version Bytes Avg Time vs remote vs branch
npm latest 487 kB 95.32ms - 97.64ms - unsure 🔍
-2% - +1%
-2.16ms - +1.11ms
branch 473 kB 95.86ms - 98.16ms unsure 🔍
-1% - +2%
-1.11ms - +2.16ms		 -

action-menu permalink

Version Bytes Avg Time vs remote vs branch
npm latest 640 kB 190.40ms - 193.51ms - unsure 🔍
-2% - +0%
-4.41ms - +0.56ms
branch 626 kB 191.94ms - 195.82ms unsure 🔍
-0% - +2%
-0.56ms - +4.41ms		 -

menu permalink

Version Bytes Avg Time vs remote vs branch
npm latest 462 kB 253.57ms - 257.91ms - unsure 🔍
-1% - +1%
-2.72ms - +3.32ms
branch 448 kB 253.35ms - 257.54ms unsure 🔍
-1% - +1%
-3.32ms - +2.72ms		 -

overlay permalink

Version Bytes Avg Time vs remote vs branch
npm latest 503 kB 59.32ms - 61.23ms - unsure 🔍
-3% - +2%
-2.03ms - +1.14ms
branch 474 kB 59.45ms - 61.98ms unsure 🔍
-2% - +3%
-1.14ms - +2.03ms		 -

picker permalink

Version Bytes Avg Time vs remote vs branch
npm latest 506 kB 648.52ms - 659.12ms - unsure 🔍
-2% - +0%
-12.47ms - +2.09ms
branch 492 kB 654.01ms - 664.00ms unsure 🔍
-0% - +2%
-2.09ms - +12.47ms		 -

popover permalink

Version Bytes Avg Time vs remote vs branch
npm latest 383 kB 23.91ms - 24.10ms - unsure 🔍
-1% - +1%
-0.24ms - +0.18ms
branch 369 kB 23.85ms - 24.22ms unsure 🔍
-1% - +1%
-0.18ms - +0.24ms		 -

split-button permalink

Version Bytes Avg Time vs remote vs branch
npm latest 712 kB 1851.82ms - 1854.19ms - unsure 🔍
-0% - -0%
-4.22ms - -0.08ms
branch 698 kB 1853.46ms - 1856.86ms unsure 🔍
+0% - +0%
+0.08ms - +4.22ms		 -

tooltip permalink

Version Bytes Avg Time vs remote vs branch
npm latest 552 kB 52.76ms - 53.40ms - unsure 🔍
-2% - +0%
-1.04ms - +0.07ms
branch 540 kB 53.12ms - 54.02ms unsure 🔍
-0% - +2%
-0.07ms - +1.04ms		 -
Firefox

action-bar permalink

Version Bytes Avg Time vs remote vs branch
npm latest 487 kB 348.39ms - 363.45ms - unsure 🔍
-2% - +3%
-7.04ms - +11.28ms
branch 473 kB 348.59ms - 359.01ms unsure 🔍
-3% - +2%
-11.28ms - +7.04ms		 -

action-menu permalink

Version Bytes Avg Time vs remote vs branch
npm latest 640 kB 479.10ms - 494.58ms - unsure 🔍
-1% - +4%
-2.43ms - +17.75ms
branch 626 kB 472.72ms - 485.64ms unsure 🔍
-4% - +0%
-17.75ms - +2.43ms		 -

menu permalink

Version Bytes Avg Time vs remote vs branch
npm latest 462 kB 701.29ms - 717.83ms - unsure 🔍
-2% - +1%
-17.42ms - +9.74ms
branch 448 kB 702.63ms - 724.17ms unsure 🔍
-1% - +2%
-9.74ms - +17.42ms		 -

overlay permalink

Version Bytes Avg Time vs remote vs branch
npm latest 580 kB 228.74ms - 235.74ms - unsure 🔍
-2% - +2%
-4.26ms - +4.46ms
branch 566 kB 229.54ms - 234.74ms unsure 🔍
-2% - +2%
-4.46ms - +4.26ms		 -

picker permalink

Version Bytes Avg Time vs remote vs branch
npm latest 506 kB 1249.01ms - 1269.63ms - unsure 🔍
-0% - +1%
-6.04ms - +16.96ms
branch 492 kB 1248.77ms - 1258.95ms unsure 🔍
-1% - +0%
-16.96ms - +6.04ms		 -

popover permalink

Version Bytes Avg Time vs remote vs branch
npm latest 383 kB 135.91ms - 154.77ms - unsure 🔍
-10% - +7%
-14.35ms - +10.47ms
branch 369 kB 139.21ms - 155.35ms unsure 🔍
-7% - +10%
-10.47ms - +14.35ms		 -

split-button permalink

Version Bytes Avg Time vs remote vs branch
npm latest 712 kB 1625.92ms - 1635.40ms - unsure 🔍
-0% - +1%
-5.42ms - +8.78ms
branch 698 kB 1623.70ms - 1634.26ms unsure 🔍
-1% - +0%
-8.78ms - +5.42ms		 -

tooltip permalink

Version Bytes Avg Time vs remote vs branch
npm latest 645 kB 179.47ms - 182.33ms - unsure 🔍
-2% - +1%
-4.39ms - +1.87ms
branch 631 kB 179.38ms - 184.94ms unsure 🔍
-1% - +2%
-1.87ms - +4.39ms		 -

@najikahalsema najikahalsema merged commit ef5617f into main Nov 9, 2023
@najikahalsema najikahalsema deleted the manual-overlay branch November 9, 2023 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@najikahalsema najikahalsema najikahalsema approved these changes

@charlessuh charlessuh Awaiting requested review from charlessuh

@Rajdeepc Rajdeepc Awaiting requested review from Rajdeepc

@blunteshwar blunteshwar Awaiting requested review from blunteshwar

@TarunAdobe TarunAdobe Awaiting requested review from TarunAdobe

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: Manual overlay dismisses like auto overlay
2 participants
@Westbrook @najikahalsema