fix(radio-group): onChange event not triggering on keyboard navigation #3592
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rajdeepc
added
bug
Rajdeepc
changed the title
Tachometer resultsChromeradio permalink
Firefoxradio permalink
|
Closed
1 task
najikahalsema
requested changes
Aug 25, 2023
There was a problem hiding this comment.
Could we get a test in Radio Group for this fix?
I don't know if we've explicitly discussed this, but it's best practise to write a test when making bug fixes so that we know it's actually fixed and can make sure other additions to the code don't cause our tests to fail. The best way to test this is to write the test before making changes (it will fail), make the change, and watch the test succeed!
the test I'd recommend for this is it("emits change events on arrow key events"). You can use the sinon/spy package to check the callCount of the change event to make sure it emits as expected.
Let me know if you have more questions!
najikahalsema
approved these changes
Aug 25, 2023
jianliao
pushed a commit
that referenced
this pull request
Aug 28, 2023
#3592) * fix(radio): onchange trigger * test: added test for change events on arrow key events --------- Co-authored-by: Rajdeep Chandra <[email protected]>
blunteshwar
pushed a commit
that referenced
this pull request
Sep 12, 2023
#3592) * fix(radio): onchange trigger * test: added test for change events on arrow key events --------- Co-authored-by: Rajdeep Chandra <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added onChange trigger when radio buttons are navigated via keyboard in a radio-group
Related issue(s)
Motivation and context
How has this been tested?
Screenshots (if appropriate)
Types of changes
Checklist
Best practices
This repository uses conventional commit syntax for each commit message; note that the GitHub UI does not use this by default so be cautious when accepting suggested changes. Avoid the "Update branch" button on the pull request and opt instead for rebasing your branch against
main.