fix(color-loupe): svg should be hidden from screen readers #3316 #3318
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
majornista
added
bug
1 task
Tachometer resultsChromecolor-area permalink
color-handle permalink
color-loupe permalink
color-slider permalink
color-wheel permalink
Firefoxcolor-area permalink
color-handle permalink
color-loupe permalink
color-slider permalink
color-wheel permalink
|
Westbrook
reviewed
Jun 22, 2023
Westbrook
force-pushed
the
3316-buga11y-colorloupe-svg-should-be-hidden-from-screen-readers
branch
from
d50c5fd to
5c03a24
Compare
Westbrook
approved these changes
Jun 26, 2023
There was a problem hiding this comment.
Confirming CI with the small tweak I made to the test, and then we should be good to go here. Thanks @majornista!
Westbrook
deleted the
3316-buga11y-colorloupe-svg-should-be-hidden-from-screen-readers
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add aria-hidden="true" to the svg within the ColorLoupe shadowDom.
Related issue(s)
Motivation and context
How has this been tested?
Screenshots (if appropriate)
Types of changes
Checklist
Best practices
This repository uses conventional commit syntax for each commit message; note that the GitHub UI does not use this by default so be cautious when accepting suggested changes. Avoid the "Update branch" button on the pull request and opt instead for rebasing your branch against
main.