Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CSS transition for modal entering and exiting. #5627

Closed
tienpv222 opened this issue Dec 24, 2023 · 1 comment · Fixed by #7488
Closed

Add CSS transition for modal entering and exiting. #5627

tienpv222 opened this issue Dec 24, 2023 · 1 comment · Fixed by #7488

Comments

@tienpv222
Copy link

Provide a general summary of the feature here

Similar to how modal is handling animation, we can use transitionstart and transitionend to support CSS transition. This is suitable for those who prefer to animate using CSS transition.

🤔 Expected Behavior?

data-entering and data-exiting can also be tied to CSS transition, or a pair of new data attributes if clarification is needed.

😯 Current Behavior

Devs can only style modal through animation.

💁 Possible Solution

No response

🔦 Context

I was writing a small helper to style Tooltip using CSS transition, and wondered if it should be included in the core. Since it's aligned with the existing support for animation, maybe it's reasonable to have it built-in too.

💻 Examples

No response

🧢 Your Company/Team

No response

🕷 Tracking Issue

No response

@LFDanLu
Copy link
Member

LFDanLu commented Jan 12, 2024

The team thinks that managing transitions would be a pretty large undertaking, perhaps an external library could help with this? We haven't looked into this yet so it would take some investigation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants