Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(contrast-colors): Add d3 as dependency #25

Merged
merged 1 commit into from
Dec 12, 2019
Merged

fix(contrast-colors): Add d3 as dependency #25

merged 1 commit into from
Dec 12, 2019

Conversation

joestrouth1
Copy link
Contributor

Description

Fixes #24

Package depended on d3 without declaring so.

To-do list

  • This pull request is ready to merge.

Should be OK to merge unless you'd prefer it be a peer dep so folks can bring their own version.

Aside:

When cloning this repo and running lerna bootstrap, it failed with the following error:

error Couldn't find any versions for "@adobe/leonardo-contrast-colors" that matches "^0.1.0"

I think this will fix itself once it's not tagged as prerelease, but as someone not super familiar with lerna it was a bit of a barrier. Wound up changing the package.json version to 0.1.0, bootstrapping, then changing back after adding d3.

@lazd
Copy link
Member

lazd commented Dec 12, 2019

@joestrouth1 good catch! Note that we don't use lerna bootstrap, instead just run yarn install since we use yarn workspaces.

I don't think it needs to be a peer dependency, so this is good to go. Thank you!

@lazd lazd merged commit 34940e0 into adobe:master Dec 12, 2019
@lazd
Copy link
Member

lazd commented Dec 12, 2019

Released @adobe/[email protected] with the corrected dep. Thanks!

@lazd
Copy link
Member

lazd commented Dec 12, 2019

Also, that issue on bootstrap was due to referring to the wrong version in the ui package. I just pushed a commit that fixes that.

@GarthDB GarthDB mentioned this pull request Mar 14, 2024
thierryc pushed a commit to thierryc/leonardo that referenced this pull request Mar 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Undeclared dependency on d3
2 participants