Catch SyntaxError and return 400 as well

[dominique-pfister]

In:

helix-universal/src/aws-adapter.js

Lines 110 to 121 in 85e54e6

	if (e instanceof TypeError && e.code === 'ERR_INVALID_CHAR') {
	// eslint-disable-next-line no-console
	console.error('invalid request header', e.message);
	return {
	statusCode: 400,
	headers: {
	'content-type': 'text/plain',
	'x-invocation-id': context.awsRequestId,
	},
	body: e.message,
	};
	}

we could additionally check whether e is of type SyntaxError, which would indicate that JSON parsing of the request body failed in body-data-wrapper.js (see adobe/helix-shared#593)

Potential downside: some genuine parsing problem elsewhere in the code might be treated as bad request.

[dominique-pfister]

Note that this would fix adobe/helix-shared#593

[tripodsan]

I don't think this should be handled here.... if the SyntaxError is thrown where no input-data is involved, i.e. reading from a backend, a 500 would be more appropriate.

[dominique-pfister]

Closing as it is now fixed in adobe/helix-shared#593