Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[semantic-release] fixes no longer released #874

Closed
dominique-pfister opened this issue Nov 27, 2023 · 2 comments
Closed

[semantic-release] fixes no longer released #874

dominique-pfister opened this issue Nov 27, 2023 · 2 comments
Assignees
@tripodsan
Labels
bug Something isn't working

Comments

@dominique-pfister
Copy link
Contributor

dominique-pfister commented Nov 27, 2023 •
edited
Loading

Apparently, since merging #867 the monorepo semantic release no longer works. There was a fix in helix-shared-indexer, in this commit: https://github.com/adobe/helix-shared/actions/runs/6784725538/job/18441587110 a week later, and the associated workflow shows that it was detected, but the package was never released.

Many thanks to @solaris007 for spotting and debugging 🙏
@dominique-pfister dominique-pfister added the bug Something isn't working label Nov 27, 2023
@solaris007
Copy link
Member

i can confirm that reverting the commit for #867 re-enables proper release and npm publish.

@tripodsan tripodsan self-assigned this Dec 4, 2023
@tripodsan
Copy link
Contributor

I reverted to the old semver

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tripodsan tripodsan

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@tripodsan @solaris007 @dominique-pfister