pipify nested function calls with pipe as the first argument. closes #216

Author: novaugust

CHANGELOG.md

@@ -49,6 +49,7 @@ This release taught Styler to try just that little bit harder when doing alias l
 ### Fixes
 
 - `pipes`: handle pipifying when the first arg is itself a pipe: `c(a |> b, d)` => `a |> b() |> c(d)` (#214, h/t @kybishop)
+- `pipes`: handle pipifying nested functions `d(c(a |> b))` => `a |> b |> c() |> d` (#216, h/t @emkguts)
 - `with`: correctly handle a stabby `with` `, else: (_ -> :ok)` being rewritten to a case (#219, h/t @iamhassangm)
 
 ## 1.3.3

lib/style/pipes.ex

@@ -132,7 +132,7 @@ defmodule Styler.Style.Pipes do
 
   # a(b |> c[, ...args])
   # The first argument to a function-looking node is a pipe.
-  # Maybe pipe the whole thing?
+  # Maybe pipify the whole thing?
   def run({{f, m, [{:|>, _, _} = pipe | args]}, _} = zipper, ctx) do
     parent =
       case Zipper.up(zipper) do
@@ -168,10 +168,11 @@ defmodule Styler.Style.Pipes do
         {:cont, zipper, ctx}
 
       true ->
-        # Recurse in case this is a multi pipe
-        zipper
-        |> Zipper.replace({:|>, m, [pipe, {f, m, args}]})
-        |> run(ctx)
+        zipper = Zipper.replace(zipper, {:|>, m, [pipe, {f, m, args}]})
+        # it's possible this is a nested function call `c(b(a |> b))`, so we should walk up the tree for de-nesting
+        zipper = Zipper.up(zipper) || zipper
+        # recursion ensures we get those nested function calls and any additional pipes
+        run(zipper, ctx)
     end
   end
 

test/style/pipes_test.exs

@@ -943,9 +943,8 @@ defmodule Styler.Style.PipesTest do
     end
 
     test "pipifying" do
-      assert_style "d(a |> b |> c)", "a |> b() |> c() |> d()"
-      assert_style("c(a |> b, d)", "a |> b() |> c(d)")
-
+      assert_style("e(d(a |> b |> c), f)", "a |> b() |> c() |> d() |> e(f)")
+      
       assert_style(
         """
         # d

test/support/style_case.ex

@@ -82,6 +82,7 @@ defmodule Styler.StyleCase do
                 _ -> false
               end
 
+          # This isn't enabled in any test, but can be a useful audit
           if @ordered_siblings do
             case Zipper.left(zipper) do
               {{_, prev_meta, _} = prev, _} ->