Refactor deprecated code

[derrabauke]

The following list of deprecations must be processed.

deprecation-workflow.js:

    { handler: "silence", matchId: "ember-global" },
    { handler: "silence", matchId: "ember.component.reopen" },
    { handler: "silence", matchId: "ember-metal.get-with-default" },
    { handler: "silence", matchId: "implicit-injections" },
    { handler: "silence", matchId: "ember-views.curly-components.jquery-element" },
    { handler: "silence", matchId: "deprecated-run-loop-and-computed-dot-access" },
    { handler: "silence", matchId: "ember-utils.try-invoke" },
    { handler: "silence", matchId: "this-property-fallback" },
    { handler: "silence", matchId: "autotracking.mutation-after-consumption" },
    { handler: "silence", matchId: "manager-capabilities.modifiers-3-13" },
    { handler: "silence", matchId: "setting-on-hash" },
    { handler: "silence", matchId: "routing.transition-methods" },

How to:

Run ember test -s and delete a line from deprecation-workflow.js and fix the error's that occur. When finished with one delete the next line and so on.

---

PRs

adfinis/timed-frontend#785

[MitanOmar]

Fixed with PR adfinis/timed-frontend#893

[derrabauke]

I think we are not done yet. ;)

[c0rydoras]

@derrabauke whats the current state of this?

[derrabauke]

Seems like we have two open todos. But honestly didn't touch the codebase for a while.

/* eslint-disable no-undef */
window.deprecationWorkflow = window.deprecationWorkflow || {};
self.deprecationWorkflow.config = {
  workflow: [
    { handler: "silence", matchId: "ember-string.add-package" }, // https://deprecations.emberjs.com/id/ember-string-add-package
    { handler: "silence", matchId: "ensure-safe-component.string" }, // optimized-power-select
  ],
};

[c0rydoras]

AFAICT just one

Note! As of May 19, 2023 there is a bug in the implementation of the @ember/string deprecation. Adding @ember/string to your project may not be enough to silence the deprecation. You may silence the deprecation by using ember-cli-deprecation-workflow.