feat(button): ✨ add react aria buttons #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for renderless-components ready! Built with commit c0f4f22 |
|
Added |
anuraghazra
reviewed
Aug 31, 2020
|
Hey @navin-moorthy i've requested some minor changes and asked a few questions to clear up my confusions :) address them whenever you have some free time to do so. |
|
Merged with master to resolve conflicts and updated some packages to latest version. Do check these and approve the PR to merge. |
|
LGTM! |
anuraghazra
approved these changes
Sep 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Road to add all React Aria components for our use case