Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: React HotgraphicPopup error for conditional id attribute #332

Merged
merged 2 commits into from
Nov 20, 2024
Merged

Fix: React HotgraphicPopup error for conditional id attribute #332

merged 2 commits into from
Nov 20, 2024

Conversation

danielghost
Copy link
Contributor

Fixes #331.

Fix

  • React HotgraphicPopup error for conditional id attribute.

@danielghost danielghost self-assigned this Nov 18, 2024
kirsty-hames
kirsty-hames approved these changes Nov 19, 2024
View reviewed changes
Copy link
Contributor

@kirsty-hames kirsty-hames left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor eslint comment but fix confirmed 👍

templates/hotgraphicPopup.jsx Outdated Show resolved Hide resolved
cahirodoherty-learningpool
cahirodoherty-learningpool approved these changes Nov 19, 2024
View reviewed changes
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀

@joe-allen-89 joe-allen-89 merged commit 0aeef85 into master Nov 20, 2024
@joe-allen-89 joe-allen-89 deleted the issue/331 branch November 20, 2024 09:59
github-actions bot pushed a commit that referenced this pull request Nov 20, 2024
@semantic-release-bot
Chore(release): 6.15.2 [skip ci]
1dbfc87 
## [6.15.2](v6.15.1...v6.15.2) (2024-11-20)

### Fix

* React HotgraphicPopup error for conditional `id` attribute (fixes #332) ([0aeef85](0aeef85)), closes [#332](#332) [#331](#331)
@github-actions GitHub Actions
Copy link

🎉 This PR is included in version 6.15.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kirsty-hames kirsty-hames kirsty-hames approved these changes

@oliverfoster oliverfoster oliverfoster approved these changes

@cahirodoherty-learningpool cahirodoherty-learningpool cahirodoherty-learningpool approved these changes

Assignees

@danielghost danielghost

Labels
bug released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

React HotgraphicPopup error
5 participants
@danielghost @kirsty-hames @oliverfoster @cahirodoherty-learningpool @joe-allen-89