Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Navigation Button API #338

Closed
oliverfoster opened this issue Mar 30, 2023 · 1 comment · Fixed by #339
Closed

Navigation Button API #338

oliverfoster opened this issue Mar 30, 2023 · 1 comment · Fixed by #339
Assignees
@oliverfoster
Labels
enhancement released

Comments

@oliverfoster
Copy link
Member

oliverfoster commented Mar 30, 2023 •
edited
Loading

Subject of the issue

Allow extensions to define buttons and add them to the navigation bar rather than allowing DOM injection.

  • Backward compatible with injection
  • Text label based upon the button aria label
  • Ordering
  • Icons
  • Show/hide text
@oliverfoster oliverfoster self-assigned this Mar 30, 2023
@oliverfoster oliverfoster changed the title Navigation API Navigation Button API Mar 30, 2023
@oliverfoster oliverfoster mentioned this issue Mar 30, 2023
Merged
@oliverfoster oliverfoster moved this from New to Needs Reviewing in adapt_framework: The TODO Board Mar 30, 2023
This was referenced Apr 4, 2023
Closed
Closed
@github-project-automation github-project-automation bot moved this from Needs Reviewing to Recently Released in adapt_framework: The TODO Board May 2, 2023
@oliverfoster
Copy link
Member Author

🎉 This issue has been resolved in version 6.34.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@oliverfoster oliverfoster

Labels
enhancement released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

New: Added Navigation Button API adaptlearning/adapt-contrib-core
1 participant
@oliverfoster