Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Removed deprecated behaviour (fixes #175) #176

Merged
merged 1 commit into from
Sep 6, 2022
Merged

Fix: Removed deprecated behaviour (fixes #175) #176

merged 1 commit into from
Sep 6, 2022

Conversation

oliverfoster
Copy link
Member

fixes #175

Fix

  • Use isTypeGroup('question') rather than isTypeGroup('questions')

@oliverfoster oliverfoster self-assigned this Aug 15, 2022
cahirodoherty-learningpool
cahirodoherty-learningpool approved these changes Aug 15, 2022
View reviewed changes
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀

joe-allen-89
joe-allen-89 approved these changes Aug 16, 2022
View reviewed changes
Copy link
Contributor

@joe-allen-89 joe-allen-89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with FW v5.20.0 working as expected.

@oliverfoster oliverfoster merged commit 8703d6d into master Sep 6, 2022
@oliverfoster oliverfoster deleted the issue/175 branch September 6, 2022 09:18
github-actions bot pushed a commit that referenced this pull request Sep 6, 2022
@semantic-release-bot
Chore(release): 5.1.4 [skip ci]
67412e5 
## [5.1.4](v5.1.3...v5.1.4) (2022-09-06)

### Fix

* Removed deprecated behaviour (fixes #175) (#176) ([8703d6d](8703d6d)), closes [#175](#175) [#176](#176)
@github-actions
Copy link

github-actions bot commented Sep 6, 2022

🎉 This PR is included in version 5.1.4 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cahirodoherty-learningpool cahirodoherty-learningpool cahirodoherty-learningpool approved these changes

@eleanor-heath eleanor-heath eleanor-heath approved these changes

@joe-allen-89 joe-allen-89 joe-allen-89 approved these changes

Assignees

@oliverfoster oliverfoster

Labels
bug released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove deprecated behaviour
4 participants
@oliverfoster @cahirodoherty-learningpool @eleanor-heath @joe-allen-89