Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Packages are redundantly recreated #682

Closed
adamralph opened this issue Mar 4, 2022 · 2 comments · Fixed by #684
Closed

Packages are redundantly recreated #682

adamralph opened this issue Mar 4, 2022 · 2 comments · Fixed by #684
Labels
bug Something isn't working
Milestone
3.0.0

Comments

@adamralph
Copy link
Owner

adamralph commented Mar 4, 2022 •
edited
Loading

Version(s)

1.0.0 to 2.5.0.

To reproduce

Steps to reproduce the behaviour:

  1. Create a class library
  2. Add a package reference to MinVer 2.5.0
  3. Multi-target the class library. E.g. <TargetFrameworks>net5.0;net6.0</TargetFrameworks>
  4. Run dotnet build
  5. Run dotnet pack
  6. Run dotnet pack again

Expected behaviour

The package is created during the first dotnet pack but not during the second dotnet pack.

Actual behaviour

The package is created during both the first dotnet pack and the second dotnet pack.

Workarounds

Ignore the problem and live with the redundant resource usage.

Additional context

Thanks to @xoofx for raising the problem in #675.
@adamralph adamralph added the bug Something isn't working label Mar 4, 2022
@adamralph adamralph added this to the 3.0.0 milestone Mar 4, 2022
This was referenced Mar 4, 2022
Closed
Merged
@adamralph adamralph changed the title Packages are created redundantly when they already exist and their inputs haven't changed Packages are recreated redundantly when their inputs haven't changed Mar 4, 2022
@adamralph adamralph changed the title Packages are recreated redundantly when their inputs haven't changed Packages are redundantly recreated when their inputs haven't changed Mar 4, 2022
@adamralph adamralph changed the title Packages are redundantly recreated when their inputs haven't changed Packages are redundantly recreated Mar 4, 2022
@adamralph adamralph mentioned this issue Mar 4, 2022
Merged
@adamralph adamralph linked a pull request Mar 4, 2022 that will close this issue
fix target injection for clean and pack #684
Merged
@adamralph
Copy link
Owner Author

fixed in #684

@adamralph
Copy link
Owner Author

@xoofx I've released this in 3.0.0-rc.2. If all goes well I'll push out 3.0.0 soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
3.0.0
Development

Successfully merging a pull request may close this issue.

fix target injection for clean and pack adamralph/minver
1 participant
@adamralph