Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configurable default pre-release phase #246

Closed
adamralph opened this issue Aug 3, 2019 · 4 comments · Fixed by #245
Closed

Configurable default pre-release phase #246

adamralph opened this issue Aug 3, 2019 · 4 comments · Fixed by #245
Labels
enhancement New feature or request
Milestone

Comments

@adamralph
Copy link
Owner

adamralph commented Aug 3, 2019

Outcome of #242, raised by @Selmirrrrr.

Historically, the default pre-release phase was hardcoded to "alpha". As stated in the README, this resulted in a default version of 0.0.0-alpha.0.{height} or a post-RTM version of {major}.{minor}.{patch+1}-alpha.0.{height}. E.g. the next commit after a 1.0.0 tag would be versioned 1.0.1-alpha.0.1.

This feature introduces a new option for the default pre-release phase. For example, the option may be set to "preview":

  • Using the MinVer package:
    <MinVerDefaultPreReleasePhase>preview<MinVerDefaultPreReleasePhase>
  • Using the minver-cli package:
    minver --default-pre-release-phase preview

This will result in a default version of 0.0.0-preview.0.{height} or a post-RTM version of {major}.{minor}.{patch+1}-preview.0.{height}. E.g. the next commit after a 1.0.0 tag would be versioned 1.0.1-preview.0.1.

@adamralph
Copy link
Owner Author

@Selmirrrrr @fuzzzerd I've released this in 1.2.0-beta.1 if you want to give it a try.

@Selmirrrrr
Copy link
Contributor

@adamralph great ! I'll play with it tonight and update our projects using MinVer to this 1.2.0-beta.1 version.

@fuzzzerd
Copy link

fuzzzerd commented Aug 4, 2019

@adamralph Seems to behave as advertised. Thanks for releasing it promptly. @Selmirrrrr thanks for implementing this.

@adamralph adamralph mentioned this issue Aug 5, 2019
16 tasks
@Selmirrrrr
Copy link
Contributor

@adamralph everything seems working as expected 🔥

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants