-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HTTPBasicAuth Feature #180
Comments
@FoamyGuy I think that makes sense. Happy to tackle this if you want |
@justmobilize sounds good, you can if you'd like. Thank you! |
@FoamyGuy and @dhalbert I've got this working locally, but have a question. In CPython it's It's not like it's very big, but if we wanted to add more features, allowing things to be broken up makes sense... |
Breaking it up from a single file to a directory with multiple files is okay IMO. So long as if it's an incompatible change we bump the major version and update examples / learn guide code that need it. It does also feel like a natural time to do it if we want to add |
@FoamyGuy do you know if |
In CPython requests it looks like there is HTTPBasicAuth which handles encoding credentials into the appropriate format. https://requests.readthedocs.io/en/latest/user/authentication/ we could add that class in the adafruit_requests library and then have matching APIs between circuitpython and CPython more closely.
Once implemented this could be used to simplify a few of the examples that make use of basic auth.
This was originally discussed in #167
The text was updated successfully, but these errors were encountered: