From 51995062711ec77626b8f7a2033ffc48b5623716 Mon Sep 17 00:00:00 2001
From: dherrada <dylan.herrada@adafruit.com>
Date: Tue, 2 Mar 2021 16:46:17 -0500
Subject: [PATCH] Removed pylint process from github workflow
Signed-off-by: dherrada <dylan.herrada@adafruit.com>
---
.github/workflows/build.yml | 8 ++------
.pre-commit-config.yaml | 15 +++++++++++++++
.pylintrc | 2 +-
3 files changed, 18 insertions(+), 7 deletions(-)
diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml
index 59baa53..621d5ef 100644
--- a/.github/workflows/build.yml
+++ b/.github/workflows/build.yml
@@ -42,18 +42,14 @@ jobs:
# (e.g. - apt-get: gettext, etc; pip: circuitpython-build-tools, requirements.txt; etc.)
run: |
source actions-ci/install.sh
- - name: Pip install pylint, Sphinx, pre-commit
+ - name: Pip install Sphinx, pre-commit
run: |
- pip install --force-reinstall pylint Sphinx sphinx-rtd-theme pre-commit
+ pip install --force-reinstall Sphinx sphinx-rtd-theme pre-commit
- name: Library version
run: git describe --dirty --always --tags
- name: Pre-commit hooks
run: |
pre-commit run --all-files
- - name: PyLint
- run: |
- pylint $( find . -path './adafruit*.py' )
- ([[ ! -d "examples" ]] || pylint --disable=missing-docstring,invalid-name,bad-whitespace $( find . -path "./examples/*.py" ))
- name: Build assets
run: circuitpython-build-bundles --filename_prefix ${{ steps.repo-name.outputs.repo-name }} --library_location .
- name: Archive bundles
diff --git a/.pre-commit-config.yaml b/.pre-commit-config.yaml
index 07f886c..354c761 100644
--- a/.pre-commit-config.yaml
+++ b/.pre-commit-config.yaml
@@ -17,3 +17,18 @@ repos:
- id: check-yaml
- id: end-of-file-fixer
- id: trailing-whitespace
+- repo: https://github.com/pycqa/pylint
+ rev: pylint-2.7.1
+ hooks:
+ - id: pylint
+ name: pylint (library code)
+ types: [python]
+ exclude: "^(docs/|examples/|setup.py$)"
+- repo: local
+ hooks:
+ - id: pylint_examples
+ name: pylint (examples code)
+ description: Run pylint rules on "examples/*.py" files
+ entry: /usr/bin/env bash -c
+ args: ['([[ ! -d "examples" ]] || for example in $(find . -path "./examples/*.py"); do pylint --disable=missing-docstring,invalid-name $example; done)']
+ language: system
diff --git a/.pylintrc b/.pylintrc
index 5c31f66..9ed669e 100644
--- a/.pylintrc
+++ b/.pylintrc
@@ -250,7 +250,7 @@ ignore-comments=yes
ignore-docstrings=yes
# Ignore imports when computing similarities.
-ignore-imports=no
+ignore-imports=yes
# Minimum lines number of a similarity.
min-similarity-lines=4