From 20c11b53f9d05cef4665ef2c754654e35c482335 Mon Sep 17 00:00:00 2001
From: Liz <liz@adafruit.com>
Date: Mon, 6 Nov 2023 15:34:17 -0500
Subject: [PATCH 1/9] Adding library and example
---
adafruit_ads7830.py | 123 ++++++++++++++++++++++++++++++++-
docs/conf.py | 14 ++--
examples/ads7830_simpletest.py | 23 ++++--
3 files changed, 147 insertions(+), 13 deletions(-)
diff --git a/adafruit_ads7830.py b/adafruit_ads7830.py
index 0d80dfa..ee44909 100644
--- a/adafruit_ads7830.py
+++ b/adafruit_ads7830.py
@@ -1,4 +1,3 @@
-# SPDX-FileCopyrightText: 2017 Scott Shawcroft, written for Adafruit Industries
# SPDX-FileCopyrightText: Copyright (c) 2023 Liz Clark for Adafruit Industries
#
# SPDX-License-Identifier: MIT
@@ -26,7 +25,127 @@
* Adafruit's Bus Device library: https://github.com/adafruit/Adafruit_CircuitPython_BusDevice
"""
-# imports
+from adafruit_bus_device.i2c_device import I2CDevice
+from micropython import const
+
+try:
+ import typing # pylint: disable=unused-import
+ from busio import I2C
+except ImportError:
+ pass
__version__ = "0.0.0+auto.0"
__repo__ = "https://github.com/adafruit/Adafruit_CircuitPython_ADS7830.git"
+
+_I2C_ADDR = const(0x48)
+
+
+class Adafruit_ADS7830:
+ """Adafruit ADS7830 ADC driver"""
+
+ # Power-down modes
+ _POWER_DOWN_MODES = [
+ 0x00, # POWER_DOWN_BETWEEN_CONVERSIONS
+ 0x01, # INTERNAL_REF_OFF_ADC_ON
+ 0x02, # INTERNAL_REF_ON_ADC_OFF
+ 0x03, # INTERNAL_REF_ON_ADC_ON (default)
+ ]
+ # Single channel selection list
+ _CHANNEL_SELECTION = [
+ 0x08, # SINGLE_CH0
+ 0x0C, # SINGLE_CH1
+ 0x09, # SINGLE_CH2
+ 0x0D, # SINGLE_CH3
+ 0x0A, # SINGLE_CH4
+ 0x0E, # SINGLE_CH5
+ 0x0B, # SINGLE_CH6
+ 0x0F, # SINGLE_CH7
+ ]
+ # Differential channel selection list
+ _DIFF_CHANNEL_SELECTION = [
+ 0x00, # DIFF_CH0_CH1
+ 0x04, # DIFF_CH1_CH0
+ 0x01, # DIFF_CH2_CH3
+ 0x05, # DIFF_CH3_CH2
+ 0x02, # DIFF_CH4_CH5
+ 0x06, # DIFF_CH5_CH4
+ 0x03, # DIFF_CH6_CH7
+ 0x07, # DIFF_CH7_CH6
+ ]
+
+ def __init__(self, i2c: I2C, address: int = _I2C_ADDR) -> None:
+ self.i2c_device = I2CDevice(i2c, address)
+
+ def _single_channel(self, channel: int, pd_mode: int = 3) -> int:
+ """ADC value in single-ended mode
+ Scales the 8-bit ADC value to a 16-bit value
+
+ :param int channel: Channel (0-7)
+ :param int pd_mode: Power-down mode
+ :return: Scaled ADC value or raise an exception if read failed
+ :rtype: int
+ """
+ if channel > 7:
+ raise ValueError("Invalid channel: must be 0-7")
+
+ command_byte = self._CHANNEL_SELECTION[channel]
+ command_byte <<= 4
+ command_byte |= self._POWER_DOWN_MODES[pd_mode] << 2
+
+ with self.i2c_device as i2c:
+ try:
+ # Buffer to store the read ADC value
+ adc_value = bytearray(1)
+ i2c.write_then_readinto(bytearray([command_byte]), adc_value)
+ # Scale the 8-bit value to 16-bit
+ return adc_value[0] << 8
+ except Exception as error:
+ raise RuntimeError(f"Failed to read value: {error}") from error
+
+ def _differential_channel(self, channel: int, pd_mode: int = 3) -> int:
+ """ADC value in differential mode
+ Scales the 8-bit ADC value to a 16-bit value
+
+ :param int channel: Positive channel for differential reading (0-7)
+ :param int pd_mode: Power-down mode
+ :return: Scaled ADC value or raise an exception if read failed
+ :rtype: int
+ """
+ if channel > 7:
+ raise ValueError("Invalid channel: must be 0-7")
+
+ command_byte = self._DIFF_CHANNEL_SELECTION[channel // 2]
+ command_byte <<= 4
+ command_byte |= self._POWER_DOWN_MODES[pd_mode] << 2
+
+ with self.i2c_device as i2c:
+ try:
+ # Buffer to store the read ADC value
+ adc_value = bytearray(1)
+ i2c.write_then_readinto(bytearray([command_byte]), adc_value)
+ # Scale the 8-bit value to 16-bit
+ return adc_value[0] << 8
+ except Exception as error:
+ raise RuntimeError(f"Failed to read value: {error}") from error
+
+ @property
+ def value(self) -> typing.List[int]:
+ """Single-ended mode ADC values for all channels
+
+ :rtype: List[int]"""
+ values = []
+ for i in range(8):
+ single_value = self._single_channel(i)
+ values.append(single_value)
+ return values
+
+ @property
+ def differential_value(self) -> typing.List[int]:
+ """Differential ADC values for all channel pairs
+
+ :rtype: List[int]"""
+ values = []
+ for i in range(0, 8, 2): # Iterate over channel pairs
+ diff_value = self._differential_channel(i)
+ values.append(diff_value)
+ return values
diff --git a/docs/conf.py b/docs/conf.py
index 2d7dd9b..a5c1fa2 100644
--- a/docs/conf.py
+++ b/docs/conf.py
@@ -23,18 +23,18 @@
"sphinx.ext.todo",
]
-# TODO: Please Read!
-# Uncomment the below if you use native CircuitPython modules such as
-# digitalio, micropython and busio. List the modules you use. Without it, the
-# autodoc module docs will fail to generate with a warning.
-autodoc_mock_imports = ["board", "busio", "micropython"]
+autodoc_mock_imports = [
+ "micropython",
+ "busio",
+ "adafruit_bus_device",
+]
autodoc_preserve_defaults = True
intersphinx_mapping = {
- "python": ("https://docs.python.org/3", None),"BusDevice": ("https://docs.circuitpython.org/projects/busdevice/en/latest/", None),
- "Register": ("https://docs.circuitpython.org/projects/register/en/latest/", None),
+ "python": ("https://docs.python.org/3", None),
+ "BusDevice": ("https://docs.circuitpython.org/projects/busdevice/en/latest/", None),
"CircuitPython": ("https://docs.circuitpython.org/en/latest/", None),
}
diff --git a/examples/ads7830_simpletest.py b/examples/ads7830_simpletest.py
index 9ed95d2..3bc737b 100644
--- a/examples/ads7830_simpletest.py
+++ b/examples/ads7830_simpletest.py
@@ -1,4 +1,19 @@
-# SPDX-FileCopyrightText: 2017 Scott Shawcroft, written for Adafruit Industries
-# SPDX-FileCopyrightText: Copyright (c) 2023 Liz Clark for Adafruit Industries
-#
-# SPDX-License-Identifier: Unlicense
+# SPDX-FileCopyrightText: 2023 Liz Clark for Adafruit Industries
+# SPDX-License-Identifier: MIT
+
+# Simple demo to read 8 analog inputs
+# from ADS7830 ADC
+
+import time
+import board
+import adafruit_ads7830
+
+i2c = board.I2C()
+
+# Initialize ADS7830
+adc = adafruit_ads7830.Adafruit_ADS7830(i2c)
+
+while True:
+ for i in range(8):
+ print(f"ADC channel {i} = {adc.value[i]}")
+ time.sleep(0.1)
From f80fc15e435f08f39c786c1ce572c6cc6747a3f2 Mon Sep 17 00:00:00 2001
From: Liz <liz@adafruit.com>
Date: Tue, 7 Nov 2023 09:35:36 -0500
Subject: [PATCH 2/9] redo API with analog_in
---
.../ads7830.py | 99 +++++++------------
adafruit_ads7830/analog_in.py | 34 +++++++
docs/api.rst | 5 +-
examples/ads7830_simpletest.py | 12 +--
4 files changed, 81 insertions(+), 69 deletions(-)
rename adafruit_ads7830.py => adafruit_ads7830/ads7830.py (52%)
create mode 100644 adafruit_ads7830/analog_in.py
diff --git a/adafruit_ads7830.py b/adafruit_ads7830/ads7830.py
similarity index 52%
rename from adafruit_ads7830.py
rename to adafruit_ads7830/ads7830.py
index ee44909..7d058c8 100644
--- a/adafruit_ads7830.py
+++ b/adafruit_ads7830/ads7830.py
@@ -2,7 +2,7 @@
#
# SPDX-License-Identifier: MIT
"""
-`adafruit_ads7830`
+:py:class:`~adafruit_ads7830.ads7830.ADS7830`
================================================================================
CircuitPython driver for the ADS7830 analog to digital converter
@@ -40,16 +40,21 @@
_I2C_ADDR = const(0x48)
-class Adafruit_ADS7830:
+class ADS7830:
"""Adafruit ADS7830 ADC driver"""
- # Power-down modes
- _POWER_DOWN_MODES = [
- 0x00, # POWER_DOWN_BETWEEN_CONVERSIONS
- 0x01, # INTERNAL_REF_OFF_ADC_ON
- 0x02, # INTERNAL_REF_ON_ADC_OFF
- 0x03, # INTERNAL_REF_ON_ADC_ON (default)
+ POWER_DOWN_MODES = [
+ 0x00,
+ 0x01,
+ 0x02,
+ 0x03,
]
+ """Power down modes
+
+ :param int 0: power down between conversions
+ :param int 1: internal reference off, ADC on
+ :param int 2: internal reference on, ADC off
+ :param int 3: internal reference on, ADC on (default)"""
# Single channel selection list
_CHANNEL_SELECTION = [
0x08, # SINGLE_CH0
@@ -73,50 +78,42 @@ class Adafruit_ADS7830:
0x07, # DIFF_CH7_CH6
]
- def __init__(self, i2c: I2C, address: int = _I2C_ADDR) -> None:
- self.i2c_device = I2CDevice(i2c, address)
-
- def _single_channel(self, channel: int, pd_mode: int = 3) -> int:
- """ADC value in single-ended mode
- Scales the 8-bit ADC value to a 16-bit value
-
- :param int channel: Channel (0-7)
- :param int pd_mode: Power-down mode
- :return: Scaled ADC value or raise an exception if read failed
- :rtype: int
+ def __init__(
+ self,
+ i2c: I2C,
+ address: int = _I2C_ADDR,
+ diff_mode: bool = False,
+ pd_mode: int = 3,
+ ) -> None:
+ """Initialization over I2C
+
+ :param int address: I2C address (default 0x48)
+ :param bool diff_mode: Select differential vs. single mode
+ :param int pd_mode: Select power down mode (default internal reference on, ADC on)
"""
- if channel > 7:
- raise ValueError("Invalid channel: must be 0-7")
-
- command_byte = self._CHANNEL_SELECTION[channel]
- command_byte <<= 4
- command_byte |= self._POWER_DOWN_MODES[pd_mode] << 2
+ self.i2c_device = I2CDevice(i2c, address)
+ self.power = self.POWER_DOWN_MODES[pd_mode]
+ self.differential_mode = diff_mode
- with self.i2c_device as i2c:
- try:
- # Buffer to store the read ADC value
- adc_value = bytearray(1)
- i2c.write_then_readinto(bytearray([command_byte]), adc_value)
- # Scale the 8-bit value to 16-bit
- return adc_value[0] << 8
- except Exception as error:
- raise RuntimeError(f"Failed to read value: {error}") from error
+ def read(self, channel: int) -> int:
+ """ADC value
- def _differential_channel(self, channel: int, pd_mode: int = 3) -> int:
- """ADC value in differential mode
Scales the 8-bit ADC value to a 16-bit value
- :param int channel: Positive channel for differential reading (0-7)
+ :param int channel: Channel (0-7)
:param int pd_mode: Power-down mode
+ :param bool diff: Differential vs. single read mode
:return: Scaled ADC value or raise an exception if read failed
:rtype: int
"""
if channel > 7:
raise ValueError("Invalid channel: must be 0-7")
-
- command_byte = self._DIFF_CHANNEL_SELECTION[channel // 2]
+ if self.differential_mode:
+ command_byte = self._DIFF_CHANNEL_SELECTION[channel // 2]
+ else:
+ command_byte = self._CHANNEL_SELECTION[channel]
command_byte <<= 4
- command_byte |= self._POWER_DOWN_MODES[pd_mode] << 2
+ command_byte |= self.power << 2
with self.i2c_device as i2c:
try:
@@ -127,25 +124,3 @@ def _differential_channel(self, channel: int, pd_mode: int = 3) -> int:
return adc_value[0] << 8
except Exception as error:
raise RuntimeError(f"Failed to read value: {error}") from error
-
- @property
- def value(self) -> typing.List[int]:
- """Single-ended mode ADC values for all channels
-
- :rtype: List[int]"""
- values = []
- for i in range(8):
- single_value = self._single_channel(i)
- values.append(single_value)
- return values
-
- @property
- def differential_value(self) -> typing.List[int]:
- """Differential ADC values for all channel pairs
-
- :rtype: List[int]"""
- values = []
- for i in range(0, 8, 2): # Iterate over channel pairs
- diff_value = self._differential_channel(i)
- values.append(diff_value)
- return values
diff --git a/adafruit_ads7830/analog_in.py b/adafruit_ads7830/analog_in.py
new file mode 100644
index 0000000..bb01e4a
--- /dev/null
+++ b/adafruit_ads7830/analog_in.py
@@ -0,0 +1,34 @@
+# SPDX-FileCopyrightText: 2023 Liz Clark for Adafruit Industries
+#
+# SPDX-License-Identifier: MIT
+
+"""
+:py:class:`~adafruit_ads7830.analog_in.AnalogIn`
+======================================================
+AnalogIn for ADC readings.
+
+* Author(s): Liz Clark
+
+"""
+
+from adafruit_ads7830.ads7830 import ADS7830
+
+
+class AnalogIn:
+ """AnalogIn Mock Implementation for ADC Reads.
+
+ :param ADS7830 adc: The ADC object.
+ :param int pin: Required pin for reading.
+ """
+
+ def __init__(self, adc: ADS7830, pin: int) -> None:
+ if not isinstance(adc, ADS7830):
+ raise ValueError("ADC object is from the ADS7830 class.")
+ self._adc = adc
+ self._pin = pin
+
+ @property
+ def value(self) -> int:
+ """Returns the value of an ADC pin as an integer in the range [0, 65535]."""
+ result = self._adc.read(self._pin)
+ return result
diff --git a/docs/api.rst b/docs/api.rst
index 499eddb..3e71d40 100644
--- a/docs/api.rst
+++ b/docs/api.rst
@@ -4,5 +4,8 @@
.. If your library file(s) are nested in a directory (e.g. /adafruit_foo/foo.py)
.. use this format as the module name: "adafruit_foo.foo"
-.. automodule:: adafruit_ads7830
+.. automodule:: adafruit_ads7830.ads7830
+ :members:
+
+.. automodule:: adafruit_ads7830.analog_in
:members:
diff --git a/examples/ads7830_simpletest.py b/examples/ads7830_simpletest.py
index 3bc737b..4ff9524 100644
--- a/examples/ads7830_simpletest.py
+++ b/examples/ads7830_simpletest.py
@@ -1,19 +1,19 @@
# SPDX-FileCopyrightText: 2023 Liz Clark for Adafruit Industries
# SPDX-License-Identifier: MIT
-# Simple demo to read 8 analog inputs
-# from ADS7830 ADC
+# Simple demo to read analog input on channel 0
import time
import board
-import adafruit_ads7830
+import adafruit_ads7830.ads7830 as ADC
+from adafruit_ads7830.analog_in import AnalogIn
i2c = board.I2C()
# Initialize ADS7830
-adc = adafruit_ads7830.Adafruit_ADS7830(i2c)
+adc = ADC.ADS7830(i2c)
+chan = AnalogIn(adc, 0)
while True:
- for i in range(8):
- print(f"ADC channel {i} = {adc.value[i]}")
+ print(f"ADC channel {0} = {chan.value}")
time.sleep(0.1)
From 101784f6e189b495df82e163b6e7daf4162d4cf6 Mon Sep 17 00:00:00 2001
From: Liz <liz@adafruit.com>
Date: Tue, 7 Nov 2023 09:41:52 -0500
Subject: [PATCH 3/9] Update pyproject.toml
---
pyproject.toml | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/pyproject.toml b/pyproject.toml
index cf20e74..c62bfd6 100644
--- a/pyproject.toml
+++ b/pyproject.toml
@@ -41,7 +41,7 @@ dynamic = ["dependencies", "optional-dependencies"]
[tool.setuptools]
# TODO: IF LIBRARY FILES ARE A PACKAGE FOLDER,
# CHANGE `py_modules = ['...']` TO `packages = ['...']`
-py-modules = ["adafruit_ads7830"]
+packages = ["adafruit_ads7830"]
[tool.setuptools.dynamic]
dependencies = {file = ["requirements.txt"]}
From 6cbac31212228a59789952d893605d7b886db6f7 Mon Sep 17 00:00:00 2001
From: Liz <liz@adafruit.com>
Date: Tue, 7 Nov 2023 09:46:37 -0500
Subject: [PATCH 4/9] Update ads7830_simpletest.py
---
examples/ads7830_simpletest.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/examples/ads7830_simpletest.py b/examples/ads7830_simpletest.py
index 4ff9524..3c0936b 100644
--- a/examples/ads7830_simpletest.py
+++ b/examples/ads7830_simpletest.py
@@ -15,5 +15,5 @@
chan = AnalogIn(adc, 0)
while True:
- print(f"ADC channel {0} = {chan.value}")
+ print(f"ADC channel 0 = {chan.value}")
time.sleep(0.1)
From f5749197dbe24b099a16d31087fd9455eb6f4f00 Mon Sep 17 00:00:00 2001
From: Liz <liz@adafruit.com>
Date: Wed, 8 Nov 2023 19:22:09 -0500
Subject: [PATCH 5/9] move power down modes to init
---
adafruit_ads7830/ads7830.py | 33 ++++++++++++++-------------------
1 file changed, 14 insertions(+), 19 deletions(-)
diff --git a/adafruit_ads7830/ads7830.py b/adafruit_ads7830/ads7830.py
index 7d058c8..d58a390 100644
--- a/adafruit_ads7830/ads7830.py
+++ b/adafruit_ads7830/ads7830.py
@@ -2,7 +2,7 @@
#
# SPDX-License-Identifier: MIT
"""
-:py:class:`~adafruit_ads7830.ads7830.ADS7830`
+`adafruit_ads7830`
================================================================================
CircuitPython driver for the ADS7830 analog to digital converter
@@ -43,18 +43,12 @@
class ADS7830:
"""Adafruit ADS7830 ADC driver"""
- POWER_DOWN_MODES = [
- 0x00,
- 0x01,
- 0x02,
- 0x03,
+ _POWER_DOWN_MODES = [
+ (True, True), # power down ref and adc
+ (True, False), # power down ref and not adc
+ (False, True), # power down adc and not ref
+ (False, False), # do not power down ref or adc
]
- """Power down modes
-
- :param int 0: power down between conversions
- :param int 1: internal reference off, ADC on
- :param int 2: internal reference on, ADC off
- :param int 3: internal reference on, ADC on (default)"""
# Single channel selection list
_CHANNEL_SELECTION = [
0x08, # SINGLE_CH0
@@ -78,31 +72,32 @@ class ADS7830:
0x07, # DIFF_CH7_CH6
]
+ # pylint: disable=too-many-arguments
def __init__(
self,
i2c: I2C,
address: int = _I2C_ADDR,
diff_mode: bool = False,
- pd_mode: int = 3,
+ int_ref_pd: bool = False,
+ adc_pd: bool = False,
) -> None:
"""Initialization over I2C
:param int address: I2C address (default 0x48)
:param bool diff_mode: Select differential vs. single mode
- :param int pd_mode: Select power down mode (default internal reference on, ADC on)
+ :param bool int_ref_pd: Power down mode for internal reference (defaults to False)
+ :param bool adc_pd: Power down mode for ADC (defaults to False)
"""
self.i2c_device = I2CDevice(i2c, address)
- self.power = self.POWER_DOWN_MODES[pd_mode]
+ _pd = (int_ref_pd, adc_pd)
+ self.power_down = self._POWER_DOWN_MODES.index(_pd)
self.differential_mode = diff_mode
def read(self, channel: int) -> int:
"""ADC value
-
Scales the 8-bit ADC value to a 16-bit value
:param int channel: Channel (0-7)
- :param int pd_mode: Power-down mode
- :param bool diff: Differential vs. single read mode
:return: Scaled ADC value or raise an exception if read failed
:rtype: int
"""
@@ -113,7 +108,7 @@ def read(self, channel: int) -> int:
else:
command_byte = self._CHANNEL_SELECTION[channel]
command_byte <<= 4
- command_byte |= self.power << 2
+ command_byte |= self.power_down << 2
with self.i2c_device as i2c:
try:
From 7f8d06dd34d5e529a0c2e24ef03f19a37a79ea48 Mon Sep 17 00:00:00 2001
From: Liz <liz@adafruit.com>
Date: Wed, 8 Nov 2023 19:54:09 -0500
Subject: [PATCH 6/9] fix docstring
---
adafruit_ads7830/ads7830.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/adafruit_ads7830/ads7830.py b/adafruit_ads7830/ads7830.py
index d58a390..a6b0af0 100644
--- a/adafruit_ads7830/ads7830.py
+++ b/adafruit_ads7830/ads7830.py
@@ -2,7 +2,7 @@
#
# SPDX-License-Identifier: MIT
"""
-`adafruit_ads7830`
+:py:class:`~adafruit_ads7830.ads7830.ADS7830`
================================================================================
CircuitPython driver for the ADS7830 analog to digital converter
From 1045b8b9efb41dfe2c1d0de671275bac75115939 Mon Sep 17 00:00:00 2001
From: Liz <liz@adafruit.com>
Date: Fri, 10 Nov 2023 10:30:33 -0500
Subject: [PATCH 7/9] remove power down list
---
adafruit_ads7830/ads7830.py | 27 ++++++++++++---------------
1 file changed, 12 insertions(+), 15 deletions(-)
diff --git a/adafruit_ads7830/ads7830.py b/adafruit_ads7830/ads7830.py
index a6b0af0..ac85393 100644
--- a/adafruit_ads7830/ads7830.py
+++ b/adafruit_ads7830/ads7830.py
@@ -43,12 +43,6 @@
class ADS7830:
"""Adafruit ADS7830 ADC driver"""
- _POWER_DOWN_MODES = [
- (True, True), # power down ref and adc
- (True, False), # power down ref and not adc
- (False, True), # power down adc and not ref
- (False, False), # do not power down ref or adc
- ]
# Single channel selection list
_CHANNEL_SELECTION = [
0x08, # SINGLE_CH0
@@ -77,21 +71,24 @@ def __init__(
self,
i2c: I2C,
address: int = _I2C_ADDR,
- diff_mode: bool = False,
- int_ref_pd: bool = False,
- adc_pd: bool = False,
+ differential_mode: bool = False,
+ int_ref_power_down: bool = False,
+ adc_power_down: bool = False,
) -> None:
"""Initialization over I2C
:param int address: I2C address (default 0x48)
- :param bool diff_mode: Select differential vs. single mode
- :param bool int_ref_pd: Power down mode for internal reference (defaults to False)
- :param bool adc_pd: Power down mode for ADC (defaults to False)
+ :param bool differential_mode: Select differential vs. single mode
+ :param bool int_ref_power_down: Power down mode for internal reference (defaults to False)
+ :param bool adc_power_down: Power down mode for ADC (defaults to False)
"""
self.i2c_device = I2CDevice(i2c, address)
- _pd = (int_ref_pd, adc_pd)
- self.power_down = self._POWER_DOWN_MODES.index(_pd)
- self.differential_mode = diff_mode
+ self.power_down = 0
+ if not int_ref_power_down:
+ self.power_down |= 2
+ if not adc_power_down:
+ self.power_down |= 1
+ self.differential_mode = differential_mode
def read(self, channel: int) -> int:
"""ADC value
From f55088979e56a5217e2fc35e9e1168219ff1705e Mon Sep 17 00:00:00 2001
From: Liz <liz@adafruit.com>
Date: Sun, 12 Nov 2023 08:25:10 -0500
Subject: [PATCH 8/9] update param definition
Co-authored-by: Scott Shawcroft <scott@tannewt.org>
---
adafruit_ads7830/ads7830.py | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/adafruit_ads7830/ads7830.py b/adafruit_ads7830/ads7830.py
index ac85393..eab3770 100644
--- a/adafruit_ads7830/ads7830.py
+++ b/adafruit_ads7830/ads7830.py
@@ -79,8 +79,8 @@ def __init__(
:param int address: I2C address (default 0x48)
:param bool differential_mode: Select differential vs. single mode
- :param bool int_ref_power_down: Power down mode for internal reference (defaults to False)
- :param bool adc_power_down: Power down mode for ADC (defaults to False)
+ :param bool int_ref_power_down: Power down internal reference after sampling
+ :param bool adc_power_down: Power down ADC after sampling
"""
self.i2c_device = I2CDevice(i2c, address)
self.power_down = 0
From 0c2dffb6d779407d8e97c9e2e9aed561f5d933bb Mon Sep 17 00:00:00 2001
From: Liz <liz@adafruit.com>
Date: Sun, 12 Nov 2023 08:27:31 -0500
Subject: [PATCH 9/9] change to temporary variable
---
adafruit_ads7830/ads7830.py | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/adafruit_ads7830/ads7830.py b/adafruit_ads7830/ads7830.py
index eab3770..4676ba7 100644
--- a/adafruit_ads7830/ads7830.py
+++ b/adafruit_ads7830/ads7830.py
@@ -83,11 +83,12 @@ def __init__(
:param bool adc_power_down: Power down ADC after sampling
"""
self.i2c_device = I2CDevice(i2c, address)
- self.power_down = 0
+ _pd = 0
if not int_ref_power_down:
- self.power_down |= 2
+ _pd |= 2
if not adc_power_down:
- self.power_down |= 1
+ _pd |= 1
+ self.power_down = _pd
self.differential_mode = differential_mode
def read(self, channel: int) -> int: