Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove random number generator hotfix #934

Open
niermann999 opened this issue Feb 14, 2025 · 0 comments
Open

Remove random number generator hotfix #934

niermann999 opened this issue Feb 14, 2025 · 0 comments
Labels
bug Something isn't working

Comments

@niermann999
Copy link
Contributor

As soon as acts-project/traccc#860 is merged, remove the workaround in

// Hotfix for the traccc wire chamber Kalman fitter CI tests: Only a
// specific set of tracks pass the test, so detray needs to make sure
// that these tracks are generated in the random_track_generator. This
// means that the correct number of draws from the random number engine
// needs to be done in order to arrive at the SAME internal state of
// 'm_engine'. TODO: Remove once the test are stable
if (is_zero_stddev) {
std::normal_distribution<scalar_t>(mean, 1.f)(m_engine);
}

@niermann999 niermann999 added the bug Something isn't working label Feb 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant