Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Post Run action inputs become null #2800

Open
kevinchen-pimq opened this issue Aug 25, 2023 · 4 comments
Open

Post Run action inputs become null #2800

kevinchen-pimq opened this issue Aug 25, 2023 · 4 comments
Labels
bug Something isn't working

Comments

@kevinchen-pimq
Copy link

Describe the bug

Post Run action inputs become null.

Happen when workflow file looks like this.

workflow --call--> action --call--> action

To Reproduce
Steps to reproduce the behavior:

  1. fork https://github.com/kevinchen-pimq/action-input-poc
  2. Run POC workflow

Expected behavior

Inputs value should not be null.

Runner Version and Platform

Version of your runner?

2.308.0

OS of the machine running the runner? OSX/Windows/Linux/...

  Ubuntu
  20.04.6
  LTS

What's not working?

Please include error messages and screenshots.
workflow run:
https://github.com/kevinchen-pimq/action-input-poc/actions/runs/5973798158

Case 1:
workflow --call--> action test-post-run-input
Post run is as expected.

Case 2:
workflow --call--> action extra-step --call--> action test-post-run-input
Post run test-post-run-input inputs become null.

image

Job Log Output

If applicable, include the relevant part of the job / step log output here. All sensitive information should already be masked out, but please double-check before pasting here.

https://github.com/kevinchen-pimq/action-input-poc/actions/runs/5973798158

Runner and Worker's Diagnostic Logs

If applicable, add relevant diagnostic log information. Logs are located in the runner's _diag folder. The runner logs are prefixed with Runner_ and the worker logs are prefixed with Worker_. Each job run correlates to a worker log. All sensitive information should already be masked out, but please double-check before pasting here.

@kevinchen-pimq kevinchen-pimq added the bug Something isn't working label Aug 25, 2023
@kevinchen-pimq
Copy link
Author

related
#2009

@jenseng
Copy link

jenseng commented Dec 7, 2023

A related problem (I think) is that an outer input of the same name can bleed into / overwrite an inner one during the post phase. I've run into a problem when using nested local actions with actions/cache where my actions have a path input. The outer path ends up clobbering the actions/cache one during its post phase, so it uses the wrong value when it tars up and caches things. Because the path is different, the cache entry gets a different version and contents, so it can't actually be used by later jobs.

E.g. this simplified example demonstrates the problem here

Copy link
Contributor

github-actions bot commented Jan 6, 2025

This issue is stale because it has been open 365 days with no activity. Remove stale label or comment or this will be closed in 15 days.

@github-actions github-actions bot added the Stale label Jan 6, 2025
@jenseng
Copy link

jenseng commented Jan 6, 2025

This bug is still present

@github-actions github-actions bot removed the Stale label Jan 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants