From 943067fe4cc39d1edb36c04478359d56ee21adf8 Mon Sep 17 00:00:00 2001
From: Bryan MacFarlane <bryanmacfarlane@github.com>
Date: Thu, 23 Apr 2020 16:33:34 -0400
Subject: [PATCH] it's pretty now and bump version
---
__tests__/basics.test.ts | 24 ++++++++++++------------
index.ts | 6 +++---
package.json | 2 +-
3 files changed, 16 insertions(+), 16 deletions(-)
diff --git a/__tests__/basics.test.ts b/__tests__/basics.test.ts
index 785af20..fd171db 100644
--- a/__tests__/basics.test.ts
+++ b/__tests__/basics.test.ts
@@ -181,47 +181,47 @@ describe('basics', () => {
it('does not pass auth with diff hostname redirects', async done => {
let headers = {
- "accept": "application/json",
- "authorization": "shhh"
+ accept: 'application/json',
+ authorization: 'shhh'
}
let res: httpm.HttpClientResponse = await _http.get(
'https://httpbin.org/redirect-to?url=' +
encodeURIComponent('https://www.httpbin.org/get'),
- headers
+ headers
)
expect(res.message.statusCode).toBe(200)
let body: string = await res.readBody()
let obj: any = JSON.parse(body)
// httpbin "fixes" the casing
- expect(obj.headers["Authorization"]).toBeUndefined()
- expect(obj.headers["authorization"]).toBeUndefined()
+ expect(obj.headers['Authorization']).toBeUndefined()
+ expect(obj.headers['authorization']).toBeUndefined()
expect(obj.url).toBe('https://www.httpbin.org/get')
done()
})
-
+
it('does not pass Auth with diff hostname redirects', async done => {
let headers = {
- "Accept": "application/json",
- "Authorization": "shhh"
+ Accept: 'application/json',
+ Authorization: 'shhh'
}
let res: httpm.HttpClientResponse = await _http.get(
'https://httpbin.org/redirect-to?url=' +
encodeURIComponent('https://www.httpbin.org/get'),
- headers
+ headers
)
expect(res.message.statusCode).toBe(200)
let body: string = await res.readBody()
let obj: any = JSON.parse(body)
// httpbin "fixes" the casing
- expect(obj.headers["Authorization"]).toBeUndefined()
- expect(obj.headers["authorization"]).toBeUndefined()
+ expect(obj.headers['Authorization']).toBeUndefined()
+ expect(obj.headers['authorization']).toBeUndefined()
expect(obj.url).toBe('https://www.httpbin.org/get')
done()
- })
+ })
it('does basic head request', async done => {
let res: httpm.HttpClientResponse = await _http.head(
diff --git a/index.ts b/index.ts
index 76465b0..e3b9854 100644
--- a/index.ts
+++ b/index.ts
@@ -388,10 +388,10 @@ export class HttpClient {
// strip authorization header if redirected to a different hostname
if (parsedRedirectUrl.hostname !== parsedUrl.hostname) {
- for(let header in headers){
+ for (let header in headers) {
// header names are case insensitive
- if (header.toLowerCase() === "authorization") {
- delete headers[header]
+ if (header.toLowerCase() === 'authorization') {
+ delete headers[header]
}
}
}
diff --git a/package.json b/package.json
index 49f2e08..e57d099 100644
--- a/package.json
+++ b/package.json
@@ -1,6 +1,6 @@
{
"name": "@actions/http-client",
- "version": "1.0.7",
+ "version": "1.0.8",
"description": "Actions Http Client",
"main": "index.js",
"scripts": {