Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update typer package version to support black #26

Closed
wants to merge 1 commit into from

Conversation

bealdav
Copy link

@bealdav bealdav commented May 9, 2022

@codecov-commenter
Copy link

Codecov Report

Merging #26 (1405de5) into main (eba0c74) will decrease coverage by 0.30%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main      #26      +/-   ##
==========================================
- Coverage   94.26%   93.96%   -0.31%     
==========================================
  Files          21       21              
  Lines         663      663              
  Branches      126      122       -4     
==========================================
- Hits          625      623       -2     
- Misses         21       22       +1     
- Partials       17       18       +1     
Impacted Files Coverage Δ
src/manifestoo/core_addons/__init__.py 92.85% <0.00%> (-7.15%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eba0c74...1405de5. Read the comment docs.

@sbidoul
Copy link
Member

sbidoul commented May 10, 2022

Hi @bealdav why is this change needed ? Is it because you install manifestoo in the same python environment as black ?
For standalone commands that are distributed on PyPI such as manifestoo, black, pre-commit, etc, I recommend installing them with pipx to avoid such conflicts.

@bealdav
Copy link
Author

bealdav commented May 10, 2022

You're right, thanks

@bealdav bealdav closed this May 10, 2022
@bealdav bealdav deleted the patch-1 branch May 10, 2022 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants