Skip to content
This repository was archived by the owner on Mar 5, 2025. It is now read-only.

Example Behat test constantly overridden #1409

Closed
danepowell opened this issue Apr 19, 2017 · 2 comments
Closed

Example Behat test constantly overridden #1409

danepowell opened this issue Apr 19, 2017 · 2 comments

Comments

@danepowell
Copy link
Contributor

danepowell commented Apr 19, 2017

BLT provides an example Behat test that expects to see a log in link on the homepage: https://github.com/acquia/blt/blob/8.x/template/tests/behat/features/Examples.feature

However, many (most?) enterprise sites probably don't have a log in link on the homepage, so projects either have to modify or remove this test. Then every time such a project updates BLT, it gets overwritten with the stock version, which is annoying.

Seems like BLT should either make the example test more generic so it doesn't need to be modified/removed, or include it in such a way that it won't get overwritten on updates.

@grasmash
Copy link
Contributor

Pretty sure we addressed this recently in #1322. Please re-open if that's not the case.

@danepowell
Copy link
Contributor Author

danepowell commented Apr 21, 2017

I understand what's happening now, that file will not be overwritten by BLT if it currently exists, but it will be added if it doesn't exist.

In our case, we removed it completely (seems kinda weird to keep an "example" test around anyway), and that's why it was being constantly re-added.

We can probably just modify it instead of removing it on our project.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants