Fixes #1403: Randomize user 1 name on install. (#1418)

Author: grasmash

phing/build.yml

@@ -75,8 +75,6 @@ docroot: ${repo.root}/docroot
 
 # Drupal Account Credentials. These are used for installing Drupal.
 drupal:
-  account.name: admin
-  account.password: admin
   account.mail: [email protected]
   locale: en
   local_settings_file: ${docroot}/sites/default/settings/local.settings.php

src/Drush/Command/BltDoctorCommand.php

@@ -257,7 +257,6 @@ public function checkAll() {
     $this->checkDrupalBootstrapped();
     $this->checkDrupalInstalled();
     $this->checkCaching();
-    $this->checkNvmExists();
     $this->checkDevDesktop();
     $this->checkCiConfig();
     $this->checkComposer();
@@ -539,28 +538,6 @@ protected function checkDbConnection() {
     $this->logOutcome(__FUNCTION__, $outcome, 'error');
   }
 
-  /**
-   * Checks that NVM exists.
-   *
-   * Note that this does not check if `nvm use` has been invoked for the correct
-   * node version.
-   */
-  protected function checkNvmExists() {
-    $home = getenv("HOME");
-    if (!file_exists("$home/.nvm")) {
-      $this->logOutcome(__FUNCTION__, [
-        'NVM does not exist.',
-        '',
-        'It is recommended that you use NVM to manage multiple versions of NodeJS on one machine.',
-        'Instructions for installing NVM can be found at:',
-        '  https://github.com/creationix/nvm#installation',
-      ], 'error');
-    }
-    else {
-      $this->logOutcome(__FUNCTION__, "NVM exists.", 'info');
-    }
-  }
-
   /**
    * Indicates whether Drupal core files exist in the docroot.
    *

src/Robo/Commands/Drupal/DrupalCommand.php

@@ -3,6 +3,7 @@
 namespace Acquia\Blt\Robo\Commands\Drupal;
 
 use Acquia\Blt\Robo\BltTasks;
+use Acquia\Blt\Robo\Common\RandomString;
 
 /**
  * Defines commands in the "drupal:*" namespace.
@@ -17,17 +18,27 @@ class DrupalCommand extends BltTasks {
    * @validateMySqlAvailable
    *
    * @return \Robo\Result
+   *   The `drush site-install` command result.
    */
   public function install() {
 
+    // Generate a random, valid username.
+    // @see \Drupal\user\Plugin\Validation\Constraint\UserNameConstraintValidator
+    $username = RandomString::string(10, FALSE,
+      function ($string) {
+        return !preg_match('/[^\x{80}-\x{F7} a-z0-9@+_.\'-]/i', $string);
+      }
+    );
+
     $task = $this->taskExec('drush site-install')
+      ->detectInteractive()
+      ->printOutput(TRUE)
       ->dir($this->getConfigValue('docroot'))
       ->arg($this->getConfigValue('project.profile.name'))
       ->rawArg("install_configure_form.update_status_module='array(FALSE,FALSE)'")
       ->option('site-name', $this->getConfigValue('project.human_name'), '=')
       ->option('site-mail', $this->getConfigValue('drupal.account.mail'), '=')
-      ->option('account-name', $this->getConfigValue('drupal.account.name'), '=')
-      ->option('account-pass', $this->getConfigValue('drupal.account.pass'), '=')
+      ->option('account-name', $username, '=')
       ->option('account-mail', $this->getConfigValue('drupal.account.mail'), '=')
       ->option('locale', $this->getConfigValue('drupal.locale'), '=')
       ->option('yes');

src/Robo/Hooks/ValidateHook.php

@@ -114,7 +114,7 @@ public function validateMySqlAvailable() {
    */
   public function validateInsideVm() {
     if ($this->getInspector()->isDrupalVmLocallyInitialized() && !$this->getInspector()->isVmCli()) {
-      throw new \Exception("You must run this command inside Drupal VM, or else do not use Drupal VM at all. Execute `vagrant ssh`, then try again.");
+      throw new \Exception("You must run this command inside Drupal VM, or else do not use Drupal VM at all. Execute `vagrant ssh` and then execute the command, or else change drush.aliases.local in blt/project.local.yml.");
     }
   }