Making security test failure more verbose. (#231)

* Improving Drupal Scaffold docs.

* Making security test failure more verbose.

Author: grasmash

template/build/core/phing/tasks/tests.xml

@@ -132,13 +132,21 @@
   </target>
 
   <!-- Ensure Drupal doesn't have any modules requiring security updates. -->
-  <!-- Intentionally removed checkreturn="true" so that this does not cause failure. -->
   <target name="tests:security-updates"
           description="Check local Drupal installation for security updates.">
     <exec dir="${docroot}"
           command="! ${drush.cmd} -n ups --check-disabled --security-only 2>/dev/null | grep 'SECURITY UPDATE'"
           checkreturn="true"
           logoutput="true"
+          returnProperty="securityPass"
           passthru="true"/>
+
+    <!-- Output message on failure. -->
+    <if>
+      <not><equals arg1="${securityPass}" arg2="0"/></not>
+      <then>
+        <echo>One or more of your dependency has an outstanding security update. Please apply update(s) immediately. Failing build.</echo>
+      </then>
+    </if>
   </target>
 </project>

template/readme/project-tasks.md

@@ -44,7 +44,7 @@ Note that Composer versioning is not identical to drupal.org versioning. See:
 
 Drupal core files can be grouped into two categories: those that are within the `docroot/core` directory, and those that are directly within the `docroot` directory (scaffold files).
 
-Scaffold files are automatically updated via the `drupal-composer/drupal-scaffold library`, which hooks into the `composer update` and `composer install` commands. If you would like to exclude any scaffold files from automated updates, see the [Drupal Scaffold configuration documentation](https://github.com/drupal-composer/drupal-scaffold#configuration). All other core files are updated in normal composer fashion.
+Scaffold files are automatically updated via the `drupal-composer/drupal-scaffold library`, which hooks into the `composer update` and `composer install` commands. If you would like to exclude any scaffold files from automated updates (e.g., .htaccess or robots.txt), see the [Drupal Scaffold configuration documentation](https://github.com/drupal-composer/drupal-scaffold#configuration). All other core files are updated in normal composer fashion.
 
 To update all drupal core files (scaffold and non-scaffold):