Adding support for custom commands in frontend and setup targets.

Author: grasmash

template/build/core/phing/build.xml

@@ -57,4 +57,27 @@
     <exec dir="${repo.root}" command="./blt.sh -q -l" passthru="true"/>
   </target>
 
+  <target name="task:execute">
+    <fail unless="${task-name}"/>
+
+    <if>
+      <available property="${task-name}.command" />
+      <then>
+        <if>
+          <available file="${tasks.${task-name}.dir}" type="dir" property="taskDirExists" />
+          <then>
+            <exec dir="${hooks.${task-name}.dir}" command="${scripts.${task-name}.command}" logoutput="true" checkreturn="true" />
+          </then>
+          <else>
+            <fail>The directory ${scripts.${task-name}.dir} does not exist. Will not run command for ${task-name}.</fail>
+          </else>
+        </if>
+      </then>
+      <else>
+        <echo>No commands are defined for ${task-name}. Skipping.</echo>
+      </else>
+    </if>
+
+  </target>
+
 </project>

template/build/core/phing/tasks/frontend.xml

@@ -1,53 +1,9 @@
 <project name="frontend" default="frontend:install">
 
-  <target name="frontend:build" depends="frontend:install" description="Uses gulp to build front end dependencies for all themes.">
-    <if>
-      <isset property="project.themes"/>
-      <then>
-        <foreach list="${project.themes}" param="frontend.theme" target="frontend:build:run"/>
-      </then>
-    </if>
+  <target name="frontend:build" description="Uses gulp to build front end dependencies for all themes.">
+    <phingcall target="task:execute">
+      <property name="task-name" value="frontend"/>
+    </phingcall>
   </target>
 
-  <target name="frontend:build:run" depends="frontend:install" description="Uses gulp to build front end dependencies for a theme.">
-    <if>
-      <!-- We assume that if the theme name is not thunder, then a subtheme of thunder is being used. -->
-      <not><equals arg1="${frontend.theme}" arg2="thunder" /></not>
-      <then>
-        <exec dir="${docroot}/themes/custom/${frontend.theme}" command="npm run build" logoutput="true" checkreturn="true" />
-      </then>
-    </if>
-
-    <property name="project.frontend.nvmrc.file" value="${docroot}/themes/custom/${frontend.theme}/.nvmrc" />
-    <if>
-      <available file="${project.frontend.nvmrc.file}" />
-      <then>
-        <copy file="${project.frontend.nvmrc.file}" todir="${repo.root}" />
-      </then>
-    </if>
-  </target>
-
-  <target name="frontend:install" description="Installs front end dependencies for themes.">
-    <!-- Enable support for multiple themes (Base + Subtheme or multisite deployments) -->
-    <if>
-      <isset property="project.themes" />
-      <then>
-        <foreach list="${project.themes}" param="frontend.theme" target="frontend:install:run"/>
-      </then>
-      <else>
-        <!-- Skip and tell user no themes were found -->
-        <echo message="No Themes were found, skipping frontend:install."/>
-      </else>
-    </if>
-  </target>
-
-  <target name="frontend:install:run" description="Installs front end dependencies for a theme.">
-    <if>
-      <!-- We assume that if the theme name is not thunder, then a subtheme of thunder is being used. -->
-      <not><equals arg1="${frontend.theme}" arg2="thunder" /></not>
-      <then>
-        <exec dir="${docroot}/themes/custom/${frontend.theme}" command="npm run install-tools" logoutput="true" checkreturn="true" />
-      </then>
-    </if>
-  </target>
 </project>

template/build/core/phing/tasks/setup.xml

@@ -18,6 +18,11 @@
   <!-- This is run when a project is cloned to a new environment. -->
   <target name="setup:build:all" description="Generates all required files for a full build. E.g., (re)builds docroot, etc."
           depends="setup:git-hooks, setup:drupal:settings, setup:behat, setup:composer:install, setup:build:profile, frontend:build">
+
+    <phingcall target="task:execute">
+      <property name="task-name" value="setup"/>
+    </phingcall>
+
   </target>
 
   <target name="setup:build:profile" description="Build a subsidiary makefile shipped with profile">

template/project.yml

@@ -40,6 +40,17 @@ drush:
     # The default drush alias to be used when no environment is specified.
   default_alias: ${drush.aliases.local}
 
+# Custom tasks that are triggered at pre-defined times in the build process.
+tasks:
+  # Executed after setup:build:all is run.
+  setup:
+    dir: ${docroot}/profiles/contrib/lighting
+    command: npm install && bower install
+  # Executed when front end assets should be generated.
+  frontend:
+    dir: ${docroot}/sites/all/themes/contrib/thunder
+    command: npm run build
+
 # Hosting environment flags.
 # Examples: acsf (Acquia Cloud Site Factory), ac (Acquia Cloud)
 # hosting: "acsf"