Skip to content

[electrophysiology_browser] Download Files and Summary components not visible when useEEGBrowserVisualizationComponents is False #9708

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
cmadjar opened this issue Mar 14, 2025 · 2 comments · May be fixed by #9742
Open

[electrophysiology_browser] Download Files and Summary components not visible when useEEGBrowserVisualizationComponents is False #9708

cmadjar opened this issue Mar 14, 2025 · 2 comments · May be fixed by #9742
Assignees
@jeffersoncasimir
Labels
27.0.0 - Bugs Bugs Found in LORIS 27 testing Module: electrophysiology_browser PR or issue related to electrophysiology_browser module
Milestone
27.0.0

Comments

@cmadjar
Copy link
Collaborator

cmadjar commented Mar 14, 2025

Describe the bug

Test plan says: Set useEEGBrowserVisualizationComponents to "No" and run make dev. Ensure it runs without failing, and that except the Signal Viewer panel, all the other components in the page display well.

Bug: the Summary and File Download components should still be viewable even is useEEGBrowserVisualizationComponents is set to "No".

When useEEGBrowserVisualizationComponents is set to "Yes", then the UI looks like:

Image

When useEEGBrowserVisualizationComponents is set to "Yes", then the UI looks like:

Image
@cmadjar
Copy link
Collaborator Author

cmadjar commented Mar 14, 2025

@laemtl we think this is a bug, as users should always be able to see the Summary and Download the files. Could you confirm?

@cmadjar cmadjar added 27.0.0 - Bugs Bugs Found in LORIS 27 testing Module: electrophysiology_browser PR or issue related to electrophysiology_browser module labels Mar 14, 2025
@cmadjar cmadjar added this to the 27.0.0 milestone Mar 14, 2025
@regisoc
Copy link
Contributor

regisoc commented Mar 17, 2025

@laemtl can you check this too once Jefferson has done it?

@jeffersoncasimir jeffersoncasimir linked a pull request Apr 9, 2025 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jeffersoncasimir jeffersoncasimir

Labels
27.0.0 - Bugs Bugs Found in LORIS 27 testing Module: electrophysiology_browser PR or issue related to electrophysiology_browser module
Projects
None yet
Milestone
27.0.0
Development

Successfully merging a pull request may close this issue.

[electrophysiology_browser] Fix conditional EEG display jeffersoncasimir/Loris
3 participants
@cmadjar @jeffersoncasimir @regisoc