Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Session interface does not provide extraData #1197

Closed
BarbecueSilver opened this issue Dec 1, 2021 · 0 comments · Fixed by #1196
Closed

Session interface does not provide extraData #1197

BarbecueSilver opened this issue Dec 1, 2021 · 0 comments · Fixed by #1196
Labels

Comments

@BarbecueSilver
Copy link
Contributor

BarbecueSilver commented Dec 1, 2021

Bug report

Describe the bug

The Session interface in packages/types/src/types/session/session.ts does not contain the optional extraData property of type object.
extraData should contain at least impersonatorUserId (optional).

To Reproduce

In the IDE the return value for findSessionByAccessToken(...) does not contain the above mentioned properties, but when you:

  1. Login as a user
  2. Start impersonating any other user
  3. Use that authToken to await accountsServer.findSessionByAccessToken(authToken);
  4. Check the result of the promise - it contains extraData: { impersonatorUserId: 'someId123321' }, as well.

Expected behavior

IDE should show that Session may also contain optional extraData (and within optional impersonatorUserId).

Additional context

Discussion

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant