From ff72ed660523f4586093f101c81cc4e7904e999f Mon Sep 17 00:00:00 2001 From: Goutham Veeramachaneni Date: Wed, 14 Jul 2021 18:36:42 +0200 Subject: [PATCH] Add metric name to metadata error (#4363) Signed-off-by: Goutham Veeramachaneni Signed-off-by: Alvin Lin --- pkg/ingester/user_metrics_metadata.go | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/pkg/ingester/user_metrics_metadata.go b/pkg/ingester/user_metrics_metadata.go index ea64df9f8e..11fe0d9828 100644 --- a/pkg/ingester/user_metrics_metadata.go +++ b/pkg/ingester/user_metrics_metadata.go @@ -4,6 +4,8 @@ import ( "sync" "time" + "github.com/prometheus/prometheus/pkg/labels" + "github.com/cortexproject/cortex/pkg/cortexpb" "github.com/cortexproject/cortex/pkg/util/validation" ) @@ -49,7 +51,7 @@ func (mm *userMetricsMetadata) add(metric string, metadata *cortexpb.MetricMetad if err := mm.limiter.AssertMaxMetadataPerMetric(mm.userID, len(set)); err != nil { validation.DiscardedMetadata.WithLabelValues(mm.userID, perMetricMetadataLimit).Inc() - return makeLimitError(perMetricMetadataLimit, mm.limiter.FormatError(mm.userID, err)) + return makeMetricLimitError(perMetricMetadataLimit, labels.FromStrings(labels.MetricName, metric), mm.limiter.FormatError(mm.userID, err)) } // if we have seen this metadata before, it is a no-op and we don't need to change our metrics.