From 7921fd6a24a5bcdc2c4fb7efd3fbb9cb6fcffa31 Mon Sep 17 00:00:00 2001 From: Thomas Druez Date: Tue, 23 May 2023 15:25:57 +0400 Subject: [PATCH] Do not display version warning when version is not set #659 "queued" run for example Signed-off-by: Thomas Druez --- scanpipe/views.py | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/scanpipe/views.py b/scanpipe/views.py index 538de597a..fc0d95e66 100644 --- a/scanpipe/views.py +++ b/scanpipe/views.py @@ -514,7 +514,10 @@ def check_run_scancode_version(self, pipeline_runs, version_limit="32.2.0"): Display a warning message if one of the ``pipeline_runs`` scancodeio_version is prior to or currently is ``old_version``. """ - if run_versions := [run.scancodeio_version for run in pipeline_runs]: + run_versions = [ + run.scancodeio_version for run in pipeline_runs if run.scancodeio_version + ] + if run_versions and min(run_versions) <= version_limit: message = ( "WARNING: Some this project pipelines have been run with an " "out of date ScanCode-toolkit version.\n" @@ -522,8 +525,7 @@ def check_run_scancode_version(self, pipeline_runs, version_limit="32.2.0"): "project and re-run the pipelines to benefit from the latest " "scan results improvements." ) - if min(run_versions) <= version_limit: - messages.warning(self.request, message) + messages.warning(self.request, message) def get_context_data(self, **kwargs): context = super().get_context_data(**kwargs)