Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build portability #10

Open
belm0 opened this issue Oct 10, 2022 · 0 comments
Open

build portability #10

belm0 opened this issue Oct 10, 2022 · 0 comments

Comments

@belm0
Copy link

belm0 commented Oct 10, 2022

I noticed a few issues in my environment

c++17 standard is not being applied

Maybe the current config only happens to work if the C++ compiler defaults to 17?

I had to add this to top level CMakeLists.txt:

set(CMAKE_CXX_STANDARD 17)

ext/google_benchmark assumes Windows

needed to disable hard-coded lib shlwapi in ext/google_benchmark/CMakeLists.txt
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@belm0