From 9562bbe6cb5ba97c3b2ef7f6fe1220324cb2ea28 Mon Sep 17 00:00:00 2001 From: Abiola Ibrahim Date: Tue, 13 Aug 2024 10:16:29 +0100 Subject: [PATCH] cli: fix broken flag for non-m3 devices on macOS 15 Signed-off-by: Abiola Ibrahim --- cmd/start.go | 4 ++-- environment/vm/lima/yaml.go | 2 +- util/macos.go | 5 +++++ 3 files changed, 8 insertions(+), 3 deletions(-) diff --git a/cmd/start.go b/cmd/start.go index abb8ec14a..2f5948c97 100644 --- a/cmd/start.go +++ b/cmd/start.go @@ -171,7 +171,7 @@ func init() { } // nested virtualization - if util.M3() && util.MacOS15OrNewer() { + if util.MacOSNestedVirtualizationSupported() { startCmd.Flags().BoolVarP(&startCmdArgs.NestedVirtualization, "nested-virtualization", "z", false, "enable nested virtualization") startCmd.Flag("nested-virtualization").Hidden = true } @@ -457,7 +457,7 @@ func prepareConfig(cmd *cobra.Command) { startCmdArgs.VZRosetta = current.VZRosetta } } - if util.MacOS15OrNewer() { + if util.MacOSNestedVirtualizationSupported() { if !cmd.Flag("nested-virtualization").Changed { startCmdArgs.NestedVirtualization = current.NestedVirtualization } diff --git a/environment/vm/lima/yaml.go b/environment/vm/lima/yaml.go index 8d8dab207..b555c106e 100644 --- a/environment/vm/lima/yaml.go +++ b/environment/vm/lima/yaml.go @@ -44,7 +44,7 @@ func newConf(ctx context.Context, conf config.Config) (l limaconfig.Config, err } } - if util.MacOS15OrNewer() { + if util.MacOSNestedVirtualizationSupported() { l.NestedVirtualization = conf.NestedVirtualization } } diff --git a/util/macos.go b/util/macos.go index c36011913..9de1073aa 100644 --- a/util/macos.go +++ b/util/macos.go @@ -29,6 +29,11 @@ func MacOS13OrNewer() bool { return minMacOSVersion("13.0.0") } // MacOS15OrNewer returns if the current OS is macOS 15 or newer. func MacOS15OrNewer() bool { return minMacOSVersion("15.0.0") } +// MacOSNestedVirtualizationSupported returns if the current device supports nested virtualization. +func MacOSNestedVirtualizationSupported() bool { + return M3() && MacOS15OrNewer() +} + func minMacOSVersion(version string) bool { if !MacOS() { return false