New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dirname broken on Windows #2

Open

patrick-boc opened this issue Jan 30, 2021 · 2 comments

patrick-boc commented Jan 30, 2021

On Windows, dirname("../data/bunny.json") returns at the following line.

computer-graphics-ray-tracing/include/dirname.h

Line 53 in d79f95e

return std::string(".");

Consequently, STL files are not loaded. No issues on Linux though.

I copied a different version of dirname.h from here, and this one worked on Windows:
https://github.com/Asmathunofficial/computer-graphics-ray-casting/blob/42d330ca88e32b1ff786156ddda07014a410e8b2/include/dirname.h

yunhaom94 commented Jan 30, 2021

Thanks for posting this, let us look into it.

Owner

abhimadan commented Jan 30, 2021

Thank you for catching this - looks like this bug was fixed in a2 but not in a3. We'll update the a3 repo accordingly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment